All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: Broken SRC_URI handling
Date: Mon, 26 Nov 2012 21:21:23 +0000	[thread overview]
Message-ID: <1353964883.21863.66.camel@ted> (raw)
In-Reply-To: <ly624ss705.fsf@ensc-virt.intern.sigma-chemnitz.de>

On Mon, 2012-11-26 at 16:45 +0100, Enrico Scholz wrote:
> Hi,
> 
> commit 07b5f84133ac79aac4e939ea5f24390ad7f940a5 introduced a regression
> with
> 
> | +            if not newpath or not os.path.exists(newpath) and path.find("*") != -1:
> 
> 
> When an SRC_URI element is not found, some directory in the search path
> is copied insted.
> 
> There should be probably added some parentheses in the expression above.
> At the moment, the 'A or B and C' above is interpreted as 'A or (B and
> C)' due to operator precedences.

I just pushed a fix for this before I read this email! We reached the
same conclusion so it should be fixed in master now :)

Cheers,

Richard




  reply	other threads:[~2012-11-26 21:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26 15:45 Broken SRC_URI handling Enrico Scholz
2012-11-26 21:21 ` Richard Purdie [this message]
2012-11-27  1:02   ` Andreas Müller
2012-11-27  6:33     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353964883.21863.66.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=enrico.scholz@sigma-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.