Broken SRC_URI handling

Broken SRC_URI handling

[Enrico Scholz]

Hi,

commit 07b5f84133ac79aac4e939ea5f24390ad7f940a5 introduced a regression
with

| +            if not newpath or not os.path.exists(newpath) and path.find("*") != -1:


When an SRC_URI element is not found, some directory in the search path
is copied insted.

There should be probably added some parentheses in the expression above.
At the moment, the 'A or B and C' above is interpreted as 'A or (B and
C)' due to operator precedences.


Enrico

Re: Broken SRC_URI handling

[Richard Purdie]

On Mon, 2012-11-26 at 16:45 +0100, Enrico Scholz wrote:
> Hi,
> 
> commit 07b5f84133ac79aac4e939ea5f24390ad7f940a5 introduced a regression
> with
> 
> | +            if not newpath or not os.path.exists(newpath) and path.find("*") != -1:
> 
> 
> When an SRC_URI element is not found, some directory in the search path
> is copied insted.
> 
> There should be probably added some parentheses in the expression above.
> At the moment, the 'A or B and C' above is interpreted as 'A or (B and
> C)' due to operator precedences.

I just pushed a fix for this before I read this email! We reached the
same conclusion so it should be fixed in master now :)

Cheers,

Richard

Re: Broken SRC_URI handling

[Andreas Müller]

On Mon, Nov 26, 2012 at 10:21 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Mon, 2012-11-26 at 16:45 +0100, Enrico Scholz wrote:
>> Hi,
>>
>> commit 07b5f84133ac79aac4e939ea5f24390ad7f940a5 introduced a regression
>> with
>>
>> | +            if not newpath or not os.path.exists(newpath) and path.find("*") != -1:
>>
>>
>> When an SRC_URI element is not found, some directory in the search path
>> is copied insted.
>>
>> There should be probably added some parentheses in the expression above.
>> At the moment, the 'A or B and C' above is interpreted as 'A or (B and
>> C)' due to operator precedences.
>
> I just pushed a fix for this before I read this email! We reached the
> same conclusion so it should be fixed in master now :)
>
> Cheers,
>
> Richard
>
Not sure if it is related but since last update I get

WARNING: Failed to fetch URL file://systemctl, attempting MIRRORS if available
ERROR: Fetcher failure: Unable to find file file://systemctl anywhere.
The paths that were searched were:
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/task-fetch
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/x86-64
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/build-linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/pn-systemd-systemctl-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/overo
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/omap3
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/armv7a
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/armv7a-vfp-neon
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/angstrom
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/class-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/forcevariable
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-1.0/
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/task-fetch
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/x86-64
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/build-linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/pn-systemd-systemctl-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/overo
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/omap3
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/armv7a
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/armv7a-vfp-neon
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/angstrom
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/class-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/forcevariable
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/task-fetch
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/x86-64
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/build-linux
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/pn-systemd-systemctl-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/overo
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/omap3
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/armv7a
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/armv7a-vfp-neon
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/angstrom
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/class-native
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/forcevariable
    /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/files/
    /home/Superandy/data/Downloads/packets/dl
ERROR: Function failed: Fetcher failure for URL: 'file://systemctl'.
Unable to fetch URL from any source.
ERROR: Logfile of failure stored in:
/home/Superandy/tmp/oe-core-eglibc/work/x86_64-linux/systemd-systemctl-native/1.0-r6/temp/log.do_fetch.13053
ERROR: Task 4 (/home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-native.bb,
do_fetch) failed with exit code '1'
NOTE: Tasks Summary: Attempted 8 tasks of which 7 didn't need to be
rerun and 1 failed.
No currently running tasks (8 of 19)

Summary: 1 task failed:
  /home/Superandy/data/oe-core/sources/meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-native.bb,
do_fetch

The file is in

.../meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl-native

but I see something like

.../meta-openembedded/meta-systemd/recipes-core/systemd/systemd-systemctl/pn-systemd-systemctl-native

Thoughts?

Andreas

Re: Broken SRC_URI handling

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Tue, Nov 27, 2012 at 02:02:17AM +0100, Andreas Müller wrote:
> On Mon, Nov 26, 2012 at 10:21 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2012-11-26 at 16:45 +0100, Enrico Scholz wrote:
> >> Hi,
> >>
> >> commit 07b5f84133ac79aac4e939ea5f24390ad7f940a5 introduced a regression
> >> with
> >>
> >> | +            if not newpath or not os.path.exists(newpath) and path.find("*") != -1:
> >>
> >>
> >> When an SRC_URI element is not found, some directory in the search path
> >> is copied insted.
> >>
> >> There should be probably added some parentheses in the expression above.
> >> At the moment, the 'A or B and C' above is interpreted as 'A or (B and
> >> C)' due to operator precedences.
> >
> > I just pushed a fix for this before I read this email! We reached the
> > same conclusion so it should be fixed in master now :)
> >
> > Cheers,
> >
> > Richard
> >
> Not sure if it is related but since last update I get
> 
> WARNING: Failed to fetch URL file://systemctl, attempting MIRRORS if available
> ERROR: Fetcher failure: Unable to find file file://systemctl anywhere.

Hi,

it's slightly different change:
http://patchwork.openembedded.org/patch/39625/

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]