* [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
@ 2012-11-27 14:49 Axel Lin
2012-12-01 23:06 ` Linus Walleij
2012-12-03 9:07 ` Thomas Abraham
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2012-11-27 14:49 UTC (permalink / raw)
To: Linus Walleij; +Cc: Thomas Abraham, Kukjin Kim, Kyungmin Park, linux-kernel
I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y &&
CONFIG_PINCTRL_EXYNOS5440=y.
Fix the build error by making pcfgs static.
LD drivers/pinctrl/built-in.o
drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here
make[2]: *** [drivers/pinctrl/built-in.o] Error 1
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-exynos5440.c | 2 +-
drivers/pinctrl/pinctrl-samsung.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-exynos5440.c b/drivers/pinctrl/pinctrl-exynos5440.c
index b8635f6..07db895 100644
--- a/drivers/pinctrl/pinctrl-exynos5440.c
+++ b/drivers/pinctrl/pinctrl-exynos5440.c
@@ -117,7 +117,7 @@ struct exynos5440_pinctrl_priv_data {
};
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char *prop_cfg;
unsigned int cfg_type;
} pcfgs[] = {
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 8f31b65..864fed8 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -37,7 +37,7 @@
#define FSUFFIX_LEN sizeof(FUNCTION_SUFFIX)
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char *prop_cfg;
unsigned int cfg_type;
} pcfgs[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
2012-11-27 14:49 [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs Axel Lin
@ 2012-12-01 23:06 ` Linus Walleij
2012-12-10 1:40 ` Kukjin Kim
2012-12-03 9:07 ` Thomas Abraham
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2012-12-01 23:06 UTC (permalink / raw)
To: Axel Lin, Kukjin Kim, Kyungmin Park; +Cc: Thomas Abraham, linux-kernel
On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin <axel.lin@ingics.com> wrote:
> I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y &&
> CONFIG_PINCTRL_EXYNOS5440=y.
>
> Fix the build error by making pcfgs static.
>
> LD drivers/pinctrl/built-in.o
> drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
> pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
> drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here
> make[2]: *** [drivers/pinctrl/built-in.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
I'm not handling the Samsung drivers for this merge window.
Samsung guys, can you please pick up this patch?
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
2012-12-01 23:06 ` Linus Walleij
@ 2012-12-10 1:40 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-12-10 1:40 UTC (permalink / raw)
To: 'Linus Walleij', 'Axel Lin',
'Kyungmin Park'
Cc: 'Thomas Abraham', linux-kernel
Linus Walleij wrote:
>
> On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin <axel.lin@ingics.com> wrote:
>
> > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y
> &&
> > CONFIG_PINCTRL_EXYNOS5440=y.
> >
> > Fix the build error by making pcfgs static.
> >
> > LD drivers/pinctrl/built-in.o
> > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
> > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
> > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first
> defined here
> > make[2]: *** [drivers/pinctrl/built-in.o] Error 1
> > make[1]: *** [drivers/pinctrl] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> I'm not handling the Samsung drivers for this merge window.
> Samsung guys, can you please pick up this patch?
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
2012-11-27 14:49 [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs Axel Lin
2012-12-01 23:06 ` Linus Walleij
@ 2012-12-03 9:07 ` Thomas Abraham
2012-12-03 9:08 ` Kukjin Kim
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Abraham @ 2012-12-03 9:07 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Kukjin Kim, Kyungmin Park, linux-kernel
On 27 November 2012 20:19, Axel Lin <axel.lin@ingics.com> wrote:
> I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y &&
> CONFIG_PINCTRL_EXYNOS5440=y.
>
> Fix the build error by making pcfgs static.
>
> LD drivers/pinctrl/built-in.o
> drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
> pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
> drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here
> make[2]: *** [drivers/pinctrl/built-in.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Thomas Abraham <thomas.abraham@linaro.org>
Dear Mr. Kim,
Could you please consider this patch in your next pull request for fixes.
Thanks,
Thomas.
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
2012-12-03 9:07 ` Thomas Abraham
@ 2012-12-03 9:08 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-12-03 9:08 UTC (permalink / raw)
To: 'Thomas Abraham', 'Axel Lin'
Cc: 'Linus Walleij', 'Kyungmin Park', linux-kernel
Thomas Abraham wrote:
>
> On 27 November 2012 20:19, Axel Lin <axel.lin@ingics.com> wrote:
> > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y
> &&
> > CONFIG_PINCTRL_EXYNOS5440=y.
> >
> > Fix the build error by making pcfgs static.
> >
> > LD drivers/pinctrl/built-in.o
> > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
> > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
> > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first
> defined here
> > make[2]: *** [drivers/pinctrl/built-in.o] Error 1
> > make[1]: *** [drivers/pinctrl] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Thomas Abraham <thomas.abraham@linaro.org>
>
> Dear Mr. Kim,
>
> Could you please consider this patch in your next pull request for fixes.
>
Sure, I will.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-10 1:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 14:49 [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs Axel Lin
2012-12-01 23:06 ` Linus Walleij
2012-12-10 1:40 ` Kukjin Kim
2012-12-03 9:07 ` Thomas Abraham
2012-12-03 9:08 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.