All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] solve memory leak for uio
@ 2012-11-29  1:09 Cong Ding
  0 siblings, 0 replies; only message in thread
From: Cong Ding @ 2012-11-29  1:09 UTC (permalink / raw)
  To: Hans J. Koch, Greg Kroah-Hartman; +Cc: linux-kernel, Cong Ding

we have to call kobject_put() to clean up the kobject after function
kobject_init(), kobject_add(), or kobject_uevent() is called. 

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/uio/uio.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 5110f36..40566fd 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -317,16 +317,18 @@ static int uio_dev_add_attributes(struct uio_device *idev)
 		ret = kobject_add(&portio->kobj, idev->portio_dir,
 							"port%d", pi);
 		if (ret)
-			goto err_portio;
+			goto err_portio_kobj;
 		ret = kobject_uevent(&portio->kobj, KOBJ_ADD);
 		if (ret)
-			goto err_portio;
+			goto err_portio_kobj;
 	}
 
 	return 0;
 
 err_portio:
-	for (pi--; pi >= 0; pi--) {
+	pi--;
+err_portio_kobj:
+	for (; pi >= 0; pi--) {
 		port = &idev->info->port[pi];
 		portio = port->portio;
 		kobject_put(&portio->kobj);
-- 
1.7.4.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-29  1:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-29  1:09 [PATCH 1/1] solve memory leak for uio Cong Ding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.