[PATCH v2] mac80211: add debugfs file for current tx rate

[PATCH v2] mac80211: add debugfs file for current tx rate

[Saravana]

Add a debugfs file showing the current tx rate.
The information available in the rc_stats file
doesn't evidently provides us the current tx rate.
This patch adds the support for the same.

Signed-off-by: Saravana <saravanad@posedge.com>
---
 net/mac80211/debugfs_sta.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 1566941..1090c24 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -322,6 +322,20 @@ static ssize_t sta_ht_capa_read(struct file *file, char __user *userbuf,
 }
 STA_OPS(ht_capa);
 
+static ssize_t sta_current_tx_rate_read(struct file *file, char __user *userbuf,
+				      size_t count, loff_t *ppos)
+{
+	struct sta_info *sta = file->private_data;
+	struct rate_info rinfo;
+	u16 rate;
+	sta_set_rate_info_tx(sta, &sta->last_tx_rate, &rinfo);
+	rate = cfg80211_calculate_bitrate(&rinfo);
+
+	return mac80211_format_buffer(userbuf, count, ppos, "%d.%d MBit/s\n",
+					rate/10, rate%10);
+}
+STA_OPS(current_tx_rate);
+
 #define DEBUGFS_ADD(name) \
 	debugfs_create_file(#name, 0400, \
 		sta->debugfs.dir, sta, &sta_ ##name## _ops);
@@ -371,6 +385,7 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
 	DEBUGFS_ADD(last_signal);
 	DEBUGFS_ADD(ht_capa);
 	DEBUGFS_ADD(last_ack_signal);
+	DEBUGFS_ADD(current_tx_rate);
 
 	DEBUGFS_ADD_COUNTER(rx_packets, rx_packets);
 	DEBUGFS_ADD_COUNTER(tx_packets, tx_packets);

Re: [PATCH v2] mac80211: add debugfs file for current tx rate

[Johannes Berg]

On Thu, 2012-11-29 at 19:22 +0530, Saravana wrote:
> Add a debugfs file showing the current tx rate.
> The information available in the rc_stats file
> doesn't evidently provides us the current tx rate.
> This patch adds the support for the same.

Applied. But it doesn't actually require the *rx* rework, so I've left
that out.

johannes

Re: [PATCH v2] mac80211: add debugfs file for current tx rate

[Saravana]

On 11/29/2012 07:26 PM, Johannes Berg wrote:
> On Thu, 2012-11-29 at 19:22 +0530, Saravana wrote:
>> Add a debugfs file showing the current tx rate.
>> The information available in the rc_stats file
>> doesn't evidently provides us the current tx rate.
>> This patch adds the support for the same.
> 
> Applied. But it doesn't actually require the *rx* rework, so I've left
> that out.
> 
*rx* rework is required for the last rx rate stat. 
After giving my rationale on the need for addition of 
last rx rate and mic failure count stat, i am waiting for 
your inputs regarding the same. 
> johannes
> 
> 

Re: [PATCH v2] mac80211: add debugfs file for current tx rate

[Johannes Berg]

On Thu, 2012-11-29 at 19:31 +0530, Saravana wrote:
> On 11/29/2012 07:26 PM, Johannes Berg wrote:
> > On Thu, 2012-11-29 at 19:22 +0530, Saravana wrote:
> >> Add a debugfs file showing the current tx rate.
> >> The information available in the rc_stats file
> >> doesn't evidently provides us the current tx rate.
> >> This patch adds the support for the same.
> > 
> > Applied. But it doesn't actually require the *rx* rework, so I've left
> > that out.
> > 
> *rx* rework is required for the last rx rate stat. 
> After giving my rationale on the need for addition of 
> last rx rate and mic failure count stat, i am waiting for 
> your inputs regarding the same. 

Oh sorry. I'm not sure I'd use it, but if you find it useful it's just
debugfs so go ahead.

johannes