From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA
Date: Sat, 01 Dec 2012 11:53:43 +0800 [thread overview]
Message-ID: <1354334023.9680.4.camel@cr0> (raw)
In-Reply-To: <20121130075254.14aac5ce@nehalam.linuxnetplumber.net>
On Fri, 2012-11-30 at 07:52 -0800, Stephen Hemminger wrote:
> I don't think these are necessary. The device is already available and
> the relationship
> can be determined from other messages. This is what RSTP daemon does.
>
Rethinking about it, I think we can just put port->dev->ifindex instead
of port->port_no in the netlink message, so patch 1/2 is not needed at
more.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA
Date: Sat, 01 Dec 2012 11:53:43 +0800 [thread overview]
Message-ID: <1354334023.9680.4.camel@cr0> (raw)
In-Reply-To: <20121130075254.14aac5ce@nehalam.linuxnetplumber.net>
On Fri, 2012-11-30 at 07:52 -0800, Stephen Hemminger wrote:
> I don't think these are necessary. The device is already available and
> the relationship
> can be determined from other messages. This is what RSTP daemon does.
>
Rethinking about it, I think we can just put port->dev->ifindex instead
of port->port_no in the netlink message, so patch 1/2 is not needed at
more.
Thanks!
next prev parent reply other threads:[~2012-12-01 3:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 9:58 [Bridge] [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Cong Wang
2012-11-30 9:58 ` Cong Wang
2012-11-30 9:58 ` [Bridge] [PATCH net-next v1 2/2] bridge: export multicast database via netlink Cong Wang
2012-11-30 9:58 ` Cong Wang
2012-11-30 11:26 ` [Bridge] " Thomas Graf
2012-11-30 11:26 ` Thomas Graf
2012-11-30 15:00 ` [Bridge] " Cong Wang
2012-11-30 15:00 ` Cong Wang
2012-11-30 15:27 ` [Bridge] " Thomas Graf
2012-11-30 15:27 ` Thomas Graf
2012-12-01 3:56 ` [Bridge] " Cong Wang
2012-12-01 3:56 ` Cong Wang
2012-11-30 9:58 ` [Bridge] [PATCH iproute2 v1] Add mdb command to bridge Cong Wang
2012-11-30 9:58 ` Cong Wang
2012-11-30 10:54 ` [Bridge] " Thomas Graf
2012-11-30 10:54 ` Thomas Graf
2012-11-30 14:50 ` [Bridge] " Cong Wang
2012-11-30 14:50 ` Cong Wang
2012-11-30 10:18 ` [Bridge] [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Thomas Graf
2012-11-30 10:18 ` Thomas Graf
2012-11-30 14:51 ` [Bridge] " Cong Wang
2012-11-30 14:51 ` Cong Wang
2012-11-30 15:52 ` [Bridge] " Stephen Hemminger
2012-11-30 15:52 ` Stephen Hemminger
2012-12-01 3:53 ` Cong Wang [this message]
2012-12-01 3:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354334023.9680.4.camel@cr0 \
--to=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.