From: Cong Wang <amwang@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>,
bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] bridge: implement multicast fast leave
Date: Tue, 04 Dec 2012 15:04:52 +0800 [thread overview]
Message-ID: <1354604692.15167.7.camel@cr0> (raw)
In-Reply-To: <20121204013838.GA31329@gondor.apana.org.au>
On Tue, 2012-12-04 at 09:38 +0800, Herbert Xu wrote:
> On Mon, Dec 03, 2012 at 07:53:16AM -0800, Stephen Hemminger wrote:
> > On Mon, 3 Dec 2012 22:36:03 +0800
> > Cong Wang <amwang@redhat.com> wrote:
> >
> > > Fast leave allows bridge to immediately stops the multicast
> > > traffic on the port receives IGMP Leave when IGMP snooping is enabled,
> > > no timeouts are observed.
> > >
> > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > Cc: Stephen Hemminger <shemminger@vyatta.com>
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Signed-off-by: Cong Wang <amwang@redhat.com>
> >
> > I like the feature, and it looks like an oversight in the initial design.
> > Why is this not the default, adding more options obscures it.
>
> If the port has a bridge on it then you're toast. I think this
> should be a per-port option.
Per-port sounds better than per-bridge. And I will make it enabled by
default.
Thanks!
next prev parent reply other threads:[~2012-12-04 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 14:36 [Bridge] [PATCH net-next] bridge: implement multicast fast leave Cong Wang
2012-12-03 15:53 ` Stephen Hemminger
2012-12-04 1:38 ` Herbert Xu
2012-12-04 7:04 ` Cong Wang [this message]
2012-12-04 7:07 ` Herbert Xu
2012-12-04 9:55 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354604692.15167.7.camel@cr0 \
--to=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.