* [PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel
@ 2012-12-09 3:41 Axel Lin
2012-12-09 7:03 ` Haojian Zhuang
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-12-09 3:41 UTC (permalink / raw)
To: Mark Brown; +Cc: Haojian Zhuang, Liam Girdwood, linux-kernel
BUCK2 has the update_bit setting, but current code does not set update_bit
in pm8607_set_voltage_sel.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Haojian,
I don't have the datasheet, can you check if this patch is correct or not?
Thanks,
Axel
drivers/regulator/88pm8607.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
index 2b55711..5c4879a 100644
--- a/drivers/regulator/88pm8607.c
+++ b/drivers/regulator/88pm8607.c
@@ -236,6 +236,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)
return ret;
switch (info->desc.id) {
case PM8607_ID_BUCK1:
+ case PM8607_ID_BUCK2:
case PM8607_ID_BUCK3:
ret = pm860x_set_bits(info->i2c, info->update_reg,
1 << info->update_bit,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel
2012-12-09 3:41 [PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel Axel Lin
@ 2012-12-09 7:03 ` Haojian Zhuang
0 siblings, 0 replies; 2+ messages in thread
From: Haojian Zhuang @ 2012-12-09 7:03 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, linux-kernel@vger.kernel.org
On Sun, Dec 9, 2012 at 11:41 AM, Axel Lin <axel.lin@ingics.com> wrote:
> BUCK2 has the update_bit setting, but current code does not set update_bit
> in pm8607_set_voltage_sel.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Haojian,
> I don't have the datasheet, can you check if this patch is correct or not?
> Thanks,
> Axel
> drivers/regulator/88pm8607.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
> index 2b55711..5c4879a 100644
> --- a/drivers/regulator/88pm8607.c
> +++ b/drivers/regulator/88pm8607.c
> @@ -236,6 +236,7 @@ static int pm8607_set_voltage_sel(struct regulator_dev *rdev, unsigned selector)
> return ret;
> switch (info->desc.id) {
> case PM8607_ID_BUCK1:
> + case PM8607_ID_BUCK2:
> case PM8607_ID_BUCK3:
> ret = pm860x_set_bits(info->i2c, info->update_reg,
> 1 << info->update_bit,
> --
> 1.7.9.5
>
>
>
It's unnecessary since BUCK2 is designed to control voltage of CP
domain. If CP wants to scale frequency,
it could change BUCK2. Linux won't run in CP side. It only runs in AP
side. So we don't need to control
BUCK2 in AP side.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-09 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-09 3:41 [PATCH RFT] regulator: 88pm8607: Update update_bit for BUCK2 in pm8607_set_voltage_sel Axel Lin
2012-12-09 7:03 ` Haojian Zhuang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.