From: Artem Bityutskiy <dedekind1@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] block2mtd: throttle writes by calling balance_dirty_pages_ratelimited.
Date: Thu, 13 Dec 2012 13:29:09 +0200 [thread overview]
Message-ID: <1355398149.3400.47.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20121212193215.645da577@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Wed, 2012-12-12 at 19:32 +1100, NeilBrown wrote:
>
> If you create a block2mtd device that is larger than main memory,
> and write to all of it, then lots of pages will be dirtied but
> they will never be flushed out as nothing calls any variant of
> balance_dirty_pages.
>
> It would be nice to call set_page_dirty_balance(), but that isn't exported,
> so just call balance_dirty_pages_ratelimited() directly.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Joern Engel <joern@lazybastard.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block2mtd: throttle writes by calling balance_dirty_pages_ratelimited.
Date: Thu, 13 Dec 2012 13:29:09 +0200 [thread overview]
Message-ID: <1355398149.3400.47.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20121212193215.645da577@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Wed, 2012-12-12 at 19:32 +1100, NeilBrown wrote:
>
> If you create a block2mtd device that is larger than main memory,
> and write to all of it, then lots of pages will be dirtied but
> they will never be flushed out as nothing calls any variant of
> balance_dirty_pages.
>
> It would be nice to call set_page_dirty_balance(), but that isn't exported,
> so just call balance_dirty_pages_ratelimited() directly.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-13 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 8:32 [PATCH] block2mtd: throttle writes by calling balance_dirty_pages_ratelimited NeilBrown
2012-12-13 11:29 ` Artem Bityutskiy [this message]
2012-12-13 11:29 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355398149.3400.47.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.