From: Sivaram Nair <sivaramn@nvidia.com>
To: rafael.j.wysocki@intel.com, len.brown@intel.com,
daniel.lezcano@linaro.org, khilman@ti.com, ccross@android.com,
riel@redhat.com, youquan.song@intel.com,
akpm@linux-foundation.org, shuox.liu@intel.com
Cc: linux-pm@vger.kernel.org, Sivaram Nair <sivaramn@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] cpuidle: fix finding state with min power_usage
Date: Fri, 14 Dec 2012 15:17:36 +0200 [thread overview]
Message-ID: <1355491060-970-1-git-send-email-sivaramn@nvidia.com> (raw)
Since cpuidle_state.power_usage is a signed value, use INT_MAX (instead
of -1) to init the local copies so that functions that tries to find
cpuidle states with minimum power usage works correctly even if they use
non-negative values.
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
---
drivers/cpuidle/cpuidle.c | 2 +-
| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 8df53dd..fb4a7dd 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -70,7 +70,7 @@ int cpuidle_play_dead(void)
struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);
struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
int i, dead_state = -1;
- int power_usage = -1;
+ int power_usage = INT_MAX;
if (!drv)
return -ENODEV;
--git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index bd40b94..20ea33a 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -312,7 +312,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
{
struct menu_device *data = &__get_cpu_var(menu_devices);
int latency_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY);
- int power_usage = -1;
+ int power_usage = INT_MAX;
int i;
int multiplier;
struct timespec t;
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Sivaram Nair <sivaramn@nvidia.com>
To: <rafael.j.wysocki@intel.com>, <len.brown@intel.com>,
<daniel.lezcano@linaro.org>, <khilman@ti.com>,
<ccross@android.com>, <riel@redhat.com>, <youquan.song@intel.com>,
<akpm@linux-foundation.org>, <shuox.liu@intel.com>
Cc: <linux-pm@vger.kernel.org>, Sivaram Nair <sivaramn@nvidia.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] cpuidle: fix finding state with min power_usage
Date: Fri, 14 Dec 2012 15:17:36 +0200 [thread overview]
Message-ID: <1355491060-970-1-git-send-email-sivaramn@nvidia.com> (raw)
Since cpuidle_state.power_usage is a signed value, use INT_MAX (instead
of -1) to init the local copies so that functions that tries to find
cpuidle states with minimum power usage works correctly even if they use
non-negative values.
Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
---
drivers/cpuidle/cpuidle.c | 2 +-
| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 8df53dd..fb4a7dd 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -70,7 +70,7 @@ int cpuidle_play_dead(void)
struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);
struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
int i, dead_state = -1;
- int power_usage = -1;
+ int power_usage = INT_MAX;
if (!drv)
return -ENODEV;
--git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index bd40b94..20ea33a 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -312,7 +312,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
{
struct menu_device *data = &__get_cpu_var(menu_devices);
int latency_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY);
- int power_usage = -1;
+ int power_usage = INT_MAX;
int i;
int multiplier;
struct timespec t;
--
1.7.9.5
next reply other threads:[~2012-12-14 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 13:17 Sivaram Nair [this message]
2012-12-14 13:17 ` [PATCH 1/2] cpuidle: fix finding state with min power_usage Sivaram Nair
2012-12-14 13:17 ` [PATCH 2/2] cpuidle: fix sysfs output for power_usage Sivaram Nair
2012-12-14 13:17 ` Sivaram Nair
2012-12-15 0:03 ` Rafael J. Wysocki
2012-12-17 7:38 ` Sivaram Nair
2012-12-17 7:56 ` Rafael J. Wysocki
2012-12-17 8:46 ` Sivaram Nair
2012-12-17 12:09 ` Rafael J. Wysocki
2012-12-14 17:43 ` [PATCH 1/2] cpuidle: fix finding state with min power_usage Rik van Riel
2012-12-15 0:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355491060-970-1-git-send-email-sivaramn@nvidia.com \
--to=sivaramn@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=shuox.liu@intel.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.