* [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
@ 2012-12-18 23:01 Stephen Boyd
2012-12-19 0:23 ` Jesper Juhl
[not found] ` <1355871705-19720-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Boyd @ 2012-12-18 23:01 UTC (permalink / raw)
To: Bob Liu
Cc: linux-kernel, uclinux-dist-devel, linux-arm-msm, Steven Miao,
trivial
It seems that this assignment is done twice in a row. Remove the
duplicate assignment.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: Steven Miao <realmz6@gmail.com>
Cc: trivial@kernel.org
---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
index f608f02..cb0a484 100644
--- a/arch/blackfin/kernel/time-ts.c
+++ b/arch/blackfin/kernel/time-ts.c
@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
evt->broadcast = smp_timer_broadcast;
#endif
-
-#ifdef CONFIG_SMP
- evt->broadcast = smp_timer_broadcast;
-#endif
-
-
evt->name = "bfin_core_timer";
evt->rating = 350;
evt->irq = -1;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
@ 2012-12-19 0:23 ` Jesper Juhl
[not found] ` <1355871705-19720-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
1 sibling, 0 replies; 5+ messages in thread
From: Jesper Juhl @ 2012-12-19 0:23 UTC (permalink / raw)
To: Stephen Boyd
Cc: Bob Liu, linux-kernel, uclinux-dist-devel, linux-arm-msm,
Steven Miao, trivial
On Tue, 18 Dec 2012, Stephen Boyd wrote:
> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: trivial@kernel.org
> ---
>
> Noticed while grepping for broadcast users.
>
> arch/blackfin/kernel/time-ts.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> evt->broadcast = smp_timer_broadcast;
> #endif
>
> -
> -#ifdef CONFIG_SMP
> - evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
> evt->name = "bfin_core_timer";
> evt->rating = 350;
> evt->irq = -1;
>
Looks good to me.
Feel free to add
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
if you like.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <1355871705-19720-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]
* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
@ 2012-12-20 9:40 ` Bob Liu
[not found] ` <1355871705-19720-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
1 sibling, 0 replies; 5+ messages in thread
From: Bob Liu @ 2012-12-20 9:40 UTC (permalink / raw)
To: Stephen Boyd
Cc: trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, jj-IYz4IdjRLj0sV2N9l4h3zg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
On Wed, Dec 19, 2012 at 7:01 AM, Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
>
That's right.
Will be applied, thanks.
> Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Cc: Steven Miao <realmz6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
> ---
>
> Noticed while grepping for broadcast users.
>
> arch/blackfin/kernel/time-ts.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> evt->broadcast = smp_timer_broadcast;
> #endif
>
> -
> -#ifdef CONFIG_SMP
> - evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
> evt->name = "bfin_core_timer";
> evt->rating = 350;
> evt->irq = -1;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
--
Regards,
--Bob
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
@ 2012-12-20 9:40 ` Bob Liu
0 siblings, 0 replies; 5+ messages in thread
From: Bob Liu @ 2012-12-20 9:40 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, uclinux-dist-devel, linux-arm-msm, Steven Miao,
trivial, jj
On Wed, Dec 19, 2012 at 7:01 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
>
That's right.
Will be applied, thanks.
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: trivial@kernel.org
> ---
>
> Noticed while grepping for broadcast users.
>
> arch/blackfin/kernel/time-ts.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> evt->broadcast = smp_timer_broadcast;
> #endif
>
> -
> -#ifdef CONFIG_SMP
> - evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
> evt->name = "bfin_core_timer";
> evt->rating = 350;
> evt->irq = -1;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
--
Regards,
--Bob
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAA_GA1fDv4OP+7sZ-Hxr0Zyb_gGe3Xpn7DvkokMAG2u4AByScQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
[not found] ` <CAA_GA1fDv4OP+7sZ-Hxr0Zyb_gGe3Xpn7DvkokMAG2u4AByScQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-12-24 2:32 ` realmz paranoid
0 siblings, 0 replies; 5+ messages in thread
From: realmz paranoid @ 2012-12-24 2:32 UTC (permalink / raw)
To: Bob Liu
Cc: trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, Stephen Boyd,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, jj-IYz4IdjRLj0sV2N9l4h3zg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
[-- Attachment #1.1: Type: text/plain, Size: 1433 bytes --]
yes, duplicated. should be removed.
On Thu, Dec 20, 2012 at 5:40 PM, Bob Liu <lliubbo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Wed, Dec 19, 2012 at 7:01 AM, Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> wrote:
> > It seems that this assignment is done twice in a row. Remove the
> > duplicate assignment.
> >
>
> That's right.
> Will be applied, thanks.
>
> > Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > Cc: Steven Miao <realmz6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
> > ---
> >
> > Noticed while grepping for broadcast users.
> >
> > arch/blackfin/kernel/time-ts.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/blackfin/kernel/time-ts.c
> b/arch/blackfin/kernel/time-ts.c
> > index f608f02..cb0a484 100644
> > --- a/arch/blackfin/kernel/time-ts.c
> > +++ b/arch/blackfin/kernel/time-ts.c
> > @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> > evt->broadcast = smp_timer_broadcast;
> > #endif
> >
> > -
> > -#ifdef CONFIG_SMP
> > - evt->broadcast = smp_timer_broadcast;
> > -#endif
> > -
> > -
> > evt->name = "bfin_core_timer";
> > evt->rating = 350;
> > evt->irq = -1;
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> > hosted by The Linux Foundation
> >
>
> --
> Regards,
> --Bob
>
[-- Attachment #1.2: Type: text/html, Size: 2408 bytes --]
[-- Attachment #2: Type: text/plain, Size: 213 bytes --]
_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-24 2:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
2012-12-19 0:23 ` Jesper Juhl
[not found] ` <1355871705-19720-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-12-20 9:40 ` Bob Liu
2012-12-20 9:40 ` Bob Liu
[not found] ` <CAA_GA1fDv4OP+7sZ-Hxr0Zyb_gGe3Xpn7DvkokMAG2u4AByScQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-24 2:32 ` realmz paranoid
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.