All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] watchdog: da9055: Fix invalid free of devm_ allocated data
@ 2012-12-21 13:09 Axel Lin
  0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2012-12-21 13:09 UTC (permalink / raw)
  To: Wim Van Sebroeck; +Cc: David Dajun Chen, Ashish Jangam, linux-watchdog

It is not required to free devm_ allocated data. Since kref_put
needs a valid release function, da9055_wdt_release_resources()
is not deleted.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/watchdog/da9055_wdt.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c
index 709ea1a..31d5379 100644
--- a/drivers/watchdog/da9055_wdt.c
+++ b/drivers/watchdog/da9055_wdt.c
@@ -102,10 +102,6 @@ static int da9055_wdt_ping(struct watchdog_device *wdt_dev)
 
 static void da9055_wdt_release_resources(struct kref *r)
 {
-	struct da9055_wdt_data *driver_data =
-		container_of(r, struct da9055_wdt_data, kref);
-
-	kfree(driver_data);
 }
 
 static void da9055_wdt_ref(struct watchdog_device *wdt_dev)
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-12-21 13:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-21 13:09 [PATCH] watchdog: da9055: Fix invalid free of devm_ allocated data Axel Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.