From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>
Subject: [RFC 3/8] bail out when the page is in VOLATILE vma
Date: Thu, 3 Jan 2013 13:28:01 +0900 [thread overview]
Message-ID: <1357187286-18759-4-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1357187286-18759-1-git-send-email-minchan@kernel.org>
If we found a page is in VOLATILE vma, hurry up discarding
instead of access bit check because it's very unlikey working set.
Next patch will use it.
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/rmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index 402d9da..fea01cd 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -695,10 +695,12 @@ int page_referenced_one(struct page *page, struct vm_area_struct *vma,
if (!pte)
goto out;
- if (vma->vm_flags & VM_LOCKED) {
+ if ((vma->vm_flags & VM_LOCKED) ||
+ (vma->vm_flags & VM_VOLATILE)) {
pte_unmap_unlock(pte, ptl);
*mapcount = 0; /* break early from loop */
- *vm_flags |= VM_LOCKED;
+ *vm_flags |= (vma->vm_flags & VM_LOCKED ?
+ VM_LOCKED : VM_VOLATILE);
goto out;
}
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>
Subject: [RFC 3/8] bail out when the page is in VOLATILE vma
Date: Thu, 3 Jan 2013 13:28:01 +0900 [thread overview]
Message-ID: <1357187286-18759-4-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1357187286-18759-1-git-send-email-minchan@kernel.org>
If we found a page is in VOLATILE vma, hurry up discarding
instead of access bit check because it's very unlikey working set.
Next patch will use it.
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/rmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index 402d9da..fea01cd 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -695,10 +695,12 @@ int page_referenced_one(struct page *page, struct vm_area_struct *vma,
if (!pte)
goto out;
- if (vma->vm_flags & VM_LOCKED) {
+ if ((vma->vm_flags & VM_LOCKED) ||
+ (vma->vm_flags & VM_VOLATILE)) {
pte_unmap_unlock(pte, ptl);
*mapcount = 0; /* break early from loop */
- *vm_flags |= VM_LOCKED;
+ *vm_flags |= (vma->vm_flags & VM_LOCKED ?
+ VM_LOCKED : VM_VOLATILE);
goto out;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-01-03 4:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 4:27 [RFC v5 0/8] Support volatile for anonymous range Minchan Kim
2013-01-03 4:27 ` Minchan Kim
2013-01-03 4:27 ` [RFC 1/8] Introduce new system call mvolatile Minchan Kim
2013-01-03 4:27 ` Minchan Kim
2013-01-03 18:35 ` Taras Glek
2013-01-03 18:35 ` Taras Glek
2013-01-04 4:25 ` Minchan Kim
2013-01-04 4:25 ` Minchan Kim
2013-01-17 1:48 ` John Stultz
2013-01-17 1:48 ` John Stultz
2013-01-18 5:30 ` Minchan Kim
2013-01-18 5:30 ` Minchan Kim
2013-01-03 4:28 ` [RFC 2/8] Don't allow volatile attribute on THP and KSM Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 16:27 ` Dave Hansen
2013-01-03 16:27 ` Dave Hansen
2013-01-04 2:51 ` Minchan Kim
2013-01-04 2:51 ` Minchan Kim
2013-01-03 4:28 ` Minchan Kim [this message]
2013-01-03 4:28 ` [RFC 3/8] bail out when the page is in VOLATILE vma Minchan Kim
2013-01-03 4:28 ` [RFC 4/8] add page_locked parameter in free_swap_and_cache Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 4:28 ` [RFC 5/8] Discard volatile page Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 4:28 ` [RFC 6/8] add PGVOLATILE vmstat count Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 4:28 ` [RFC 7/8] add volatile page discard hook to kswapd Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 4:28 ` [RFC 8/8] extend PGVOLATILE vmstat " Minchan Kim
2013-01-03 4:28 ` Minchan Kim
2013-01-03 17:19 ` [RFC v5 0/8] Support volatile for anonymous range Sanjay Ghemawat
2013-01-03 17:19 ` Sanjay Ghemawat
2013-01-04 5:15 ` Minchan Kim
2013-01-04 5:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357187286-18759-4-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.