Fix prelink build with automake-1.13

Fix prelink build with automake-1.13

[Marko Lindqvist]

[PATCH] fix build with automake-1.13.

Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13,
which errors out upon seeing it.
configure.in -> configure.ac rename is not strictly necessary yet,
use of deprecated name still gives only warning.

Problem in dropping obsolete constructs is that support for autotools
versions so ancient that now-obsolete way is the only way to do things.
configure.in seems to have AC_PREREQ(2.13), but with these changes
(if not earlier) such an ancient autoconf will not do.


 - ML

[PATCH] fix build with automake-1.13.

[Marko Lindqvist]

Rename autoconf input file from deprecated name configure.in to
configure.ac
Replace AM_CONFIG_HEADER obsoleted in automake-1.13 with
AC_CONFIG_HEADERS.

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
---
 trunk/{configure.in => configure.ac} |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename trunk/{configure.in => configure.ac} (98%)

diff --git a/trunk/configure.in b/trunk/configure.ac
similarity index 98%
rename from trunk/configure.in
rename to trunk/configure.ac
index 396f3ac..a90cfb2 100644
--- a/trunk/configure.in
+++ b/trunk/configure.ac
@@ -1,6 +1,6 @@
 dnl Process this file with autoconf to produce a configure script. -*-m4-*-
 AC_INIT(src/prelink.c)
-AM_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS(config.h)
 AC_PREREQ(2.13)			dnl Minimum Autoconf version required.
 AC_CANONICAL_HOST
 
-- 
1.7.10.4

Re: Fix prelink build with automake-1.13

[Mark Hatle]

On 1/3/13 1:52 AM, Marko Lindqvist wrote:
> [PATCH] fix build with automake-1.13.
>
> Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13,
> which errors out upon seeing it.
> configure.in -> configure.ac rename is not strictly necessary yet,
> use of deprecated name still gives only warning.
>
> Problem in dropping obsolete constructs is that support for autotools
> versions so ancient that now-obsolete way is the only way to do things.
> configure.in seems to have AC_PREREQ(2.13), but with these changes
> (if not earlier) such an ancient autoconf will not do.
>

Do you know if the change to AC_CONFIG_HEADER (from AM_CONFIG_HEADER) is 
supported in autoconf 2.13?  Assuming it likely is, I'll get this merged. 
Otherwise we should expect to bump the AC_PREREQ.

BTW I'll check and see if this patch is specific to the cross-prelinker or 
applicable to the upstream prelink as well.  Seems like if it's applicable there 
they may want it as well..

--Mark

>   - ML
>

Re: Fix prelink build with automake-1.13

[Mark Hatle]

On 1/3/13 10:00 AM, Mark Hatle wrote:
> On 1/3/13 1:52 AM, Marko Lindqvist wrote:
>> [PATCH] fix build with automake-1.13.
>>
>> Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13,
>> which errors out upon seeing it.
>> configure.in -> configure.ac rename is not strictly necessary yet,
>> use of deprecated name still gives only warning.
>>
>> Problem in dropping obsolete constructs is that support for autotools
>> versions so ancient that now-obsolete way is the only way to do things.
>> configure.in seems to have AC_PREREQ(2.13), but with these changes
>> (if not earlier) such an ancient autoconf will not do.
>>
>
> Do you know if the change to AC_CONFIG_HEADER (from AM_CONFIG_HEADER) is
> supported in autoconf 2.13?  Assuming it likely is, I'll get this merged.
> Otherwise we should expect to bump the AC_PREREQ.
>
> BTW I'll check and see if this patch is specific to the cross-prelinker or
> applicable to the upstream prelink as well.  Seems like if it's applicable there
> they may want it as well..

Responding to my own query.  I just checked and the cross-prelinker is already 
setup for AC_PREREQ(2.50):

http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/tree/trunk/configure.in?h=cross_prelink

(The unmodified upstream -- master branch -- is still using AC_PREREQ(2.13). 
But we don't use that in OE/Yocto Project work.)

The -- cross_prelink branch -- does still have the AM_CONFIG_HEADER.  I'll get 
that updated.  I will also rename the configure.in to configure.ac and adjust 
anything else that references that.

--Mark

> --Mark
>
>>    - ML
>>
>

[PATCH] Fix build with automake-1.13

[Marko Lindqvist]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Automake-1.13 removed long obsolete AM_CONFIG_HEADER completely (
http://lists.gnu.org/archive/html/automake/2012-12/msg00038.html ) and
errors out upon seeing it.

Attached patch replaces it with proper AC_CONFIG_HEADERS.

 I'm not subscribed to mailing list.

----

I'm mass-submitting automake-1.13 fixes. Please see what you can do so
I don't need to do the same when automake-1.14 comes out:
http://cazfi.livejournal.com/195108.html


 - ML

[-- Attachment #2: obsolete_automake_macros.patch --]
[-- Type: application/octet-stream, Size: 399 bytes --]

diff -Nurd ofono-1.12/configure.ac ofono-1.12/configure.ac
--- ofono-1.12/configure.ac	2012-12-19 21:28:44.000000000 +0200
+++ ofono-1.12/configure.ac	2013-01-12 11:18:40.681410757 +0200
@@ -2,7 +2,7 @@
 AC_INIT(ofono, 1.12)
 
 AM_INIT_AUTOMAKE([foreign subdir-objects color-tests])
-AM_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS(config.h)
 
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 

Re: [PATCH] Fix build with automake-1.13

[Andrea Galbusera]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hi Marko,

On Sat, Jan 12, 2013 at 10:22 AM, Marko Lindqvist <cazfi74@gmail.com> wrote:

> Automake-1.13 removed long obsolete AM_CONFIG_HEADER completely (
> http://lists.gnu.org/archive/html/automake/2012-12/msg00038.html ) and
> errors out upon seeing it.
>
> Attached patch replaces it with proper AC_CONFIG_HEADERS.
>
>  I'm not subscribed to mailing list.
>

FYI since I see you are not on the list: a similar patch was recently
submitted by Lucas De Marchi, and just applied by Marcel.

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 925 bytes --]