From: "Arend van Spriel" <arend@broadcom.com>
To: "Ralf Baechle" <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org,
"Arend van Spriel" <arend@broadcom.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>
Subject: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform
Date: Fri, 4 Jan 2013 19:10:05 +0100 [thread overview]
Message-ID: <1357323005-28008-1-git-send-email-arend@broadcom.com> (raw)
The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected
respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These
options depend on GPIOLIB without explicitly selecting it
so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
Fixing a Kconfig issue in our nightly Jenkins build.
Gr. AvS
---
arch/mips/bcm47xx/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
index d7af29f..ba61192 100644
--- a/arch/mips/bcm47xx/Kconfig
+++ b/arch/mips/bcm47xx/Kconfig
@@ -8,8 +8,10 @@ config BCM47XX_SSB
select SSB_DRIVER_EXTIF
select SSB_EMBEDDED
select SSB_B43_PCI_BRIDGE if PCI
+ select SSB_DRIVER_PCICORE if PCI
select SSB_PCICORE_HOSTMODE if PCI
select SSB_DRIVER_GPIO
+ select GPIOLIB
default y
help
Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.
@@ -25,6 +27,7 @@ config BCM47XX_BCMA
select BCMA_HOST_PCI if PCI
select BCMA_DRIVER_PCI_HOSTMODE if PCI
select BCMA_DRIVER_GPIO
+ select GPIOLIB
default y
help
Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.
--
1.7.10.4
next reply other threads:[~2013-01-04 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 18:10 Arend van Spriel [this message]
2013-01-04 19:48 ` [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform Hauke Mehrtens
2013-01-05 11:33 ` Sergei Shtylyov
2013-01-06 21:13 ` Arend van Spriel
2013-01-16 14:50 ` Ralf Baechle
2013-01-21 9:40 ` Arend van Spriel
2013-01-17 11:07 ` Arend Van Spriel
2013-01-17 12:57 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357323005-28008-1-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.