Re: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 04-01-2013 22:10, Arend van Spriel wrote:

> The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected
> respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These
> options depend on GPIOLIB without explicitly selecting it
> so it results in a warning when GPIOLIB is not set:

> scripts/kconfig/conf --oldconfig Kconfig
> warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
> 	dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
> 	dependencies (SSB_POSSIBLE && SSB && GPIOLIB)

> which subsequently results in compile errors.

> Cc: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> Fixing a Kconfig issue in our nightly Jenkins build.

> Gr. AvS
> ---
>   arch/mips/bcm47xx/Kconfig |    3 +++
>   1 file changed, 3 insertions(+)

> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
> index d7af29f..ba61192 100644
> --- a/arch/mips/bcm47xx/Kconfig
> +++ b/arch/mips/bcm47xx/Kconfig
> @@ -8,8 +8,10 @@ config BCM47XX_SSB
>   	select SSB_DRIVER_EXTIF
>   	select SSB_EMBEDDED
>   	select SSB_B43_PCI_BRIDGE if PCI
> +	select SSB_DRIVER_PCICORE if PCI

    This change doesn';t seem to be documented in your changelog. Maybe it's 
worth another patch?

WBR, Sergei