From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: vt8500: memory cleanup missing
Date: Fri, 11 Jan 2013 07:45:27 +1300 [thread overview]
Message-ID: <1357843527.6075.9.camel@gitbox> (raw)
In-Reply-To: <CACRpkda+1MqPp-KBe5w+pTeHChE0Daa+U97dO+d1Px_Ssi_vHg@mail.gmail.com>
On Thu, 2013-01-10 at 13:02 +0100, Linus Walleij wrote:
> On Thu, Jan 10, 2013 at 11:57 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Thu, Jan 03, 2013 at 10:47:20AM +1300, Tony Prisk wrote:
>
> >> +static int vt8500_gpio_remove(struct platform_device *pdev)
> >> +{
> >> + int i;
> >> + int ret;
> >> + const struct vt8500_gpio_data *data;
> >> + void __iomem *gpio_base = vtchip[0].base;
> >> + const struct of_device_id *of_id =
> >> + of_match_device(vt8500_gpio_dt_ids, &pdev->dev);
> >> +
> >
> > You can get at the vtchip pointer if you put it into the platform device's
> > driver data pointer. That way, you're not artificially limiting this
> > driver to just one device, and, with your changes it will go wrong if DT
> > ever lists more than one device.
>
> Good point, I'm sloppy today :-(
>
> Patch dropped.
>
> Tony pls proceed as indicated by Russell.
>
> Yours,
> Linus Walleij
I must have been having a 'stupid' day to not realise that. Will fix.
Thanks Russell.
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@secretlab.ca>,
vt8500-wm8505-linux-kernel@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: vt8500: memory cleanup missing
Date: Fri, 11 Jan 2013 07:45:27 +1300 [thread overview]
Message-ID: <1357843527.6075.9.camel@gitbox> (raw)
In-Reply-To: <CACRpkda+1MqPp-KBe5w+pTeHChE0Daa+U97dO+d1Px_Ssi_vHg@mail.gmail.com>
On Thu, 2013-01-10 at 13:02 +0100, Linus Walleij wrote:
> On Thu, Jan 10, 2013 at 11:57 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Thu, Jan 03, 2013 at 10:47:20AM +1300, Tony Prisk wrote:
>
> >> +static int vt8500_gpio_remove(struct platform_device *pdev)
> >> +{
> >> + int i;
> >> + int ret;
> >> + const struct vt8500_gpio_data *data;
> >> + void __iomem *gpio_base = vtchip[0].base;
> >> + const struct of_device_id *of_id =
> >> + of_match_device(vt8500_gpio_dt_ids, &pdev->dev);
> >> +
> >
> > You can get at the vtchip pointer if you put it into the platform device's
> > driver data pointer. That way, you're not artificially limiting this
> > driver to just one device, and, with your changes it will go wrong if DT
> > ever lists more than one device.
>
> Good point, I'm sloppy today :-(
>
> Patch dropped.
>
> Tony pls proceed as indicated by Russell.
>
> Yours,
> Linus Walleij
I must have been having a 'stupid' day to not realise that. Will fix.
Thanks Russell.
Regards
Tony P
next prev parent reply other threads:[~2013-01-10 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 21:47 [PATCH] gpio: vt8500: memory cleanup missing Tony Prisk
2013-01-02 21:47 ` Tony Prisk
2013-01-10 10:51 ` Linus Walleij
2013-01-10 10:51 ` Linus Walleij
2013-01-10 10:57 ` Russell King - ARM Linux
2013-01-10 10:57 ` Russell King - ARM Linux
2013-01-10 12:02 ` Linus Walleij
2013-01-10 12:02 ` Linus Walleij
2013-01-10 18:45 ` Tony Prisk [this message]
2013-01-10 18:45 ` Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357843527.6075.9.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.