All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.orgMinchan Kim <minchan@kernel.org>,
	Mel Gorman <mgorman@suse.de>, Andy Whitcroft <apw@shadowen.org>,
	Alexander Nyberg <alexn@dsv.su.se>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2 1/2] Fix wrong EOF compare
Date: Sun, 13 Jan 2013 05:44:33 -0600	[thread overview]
Message-ID: <1358077473.32505.10@driftwood> (raw)
In-Reply-To: <xa1tbocvby0s.fsf@mina86.com> (from mina86@mina86.com on Fri Jan 11 08:21:55 2013)

On 01/11/2013 08:21:55 AM, Michal Nazarewicz wrote:
> On Fri, Jan 11 2013, Minchan Kim <minchan@kernel.org> wrote:
> > The C standards allows the character type char to be singed or  
> unsinged,
> > depending on the platform and compiler. Most of systems uses signed  
> char,
> > but those based on PowerPC and ARM processors typically use  
> unsigned char.
> > This can lead to unexpected results when the variable is used to  
> compare
> > with EOF(-1). It happens my ARM system and this patch fixes it.
> >
> > Cc: Mel Gorman <mgorman@suse.de>
> > Cc: Andy Whitcroft <apw@shadowen.org>
> > Cc: Alexander Nyberg <alexn@dsv.su.se>
> > Cc: Michal Nazarewicz <mina86@mina86.com>
> 
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> >  Documentation/page_owner.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)

My kernel tree doesn't have Documentation/page_owner.c, where do I find  
this file?

Rob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Andy Whitcroft <apw@shadowen.org>,
	Alexander Nyberg <alexn@dsv.su.se>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2 1/2] Fix wrong EOF compare
Date: Sun, 13 Jan 2013 05:44:33 -0600	[thread overview]
Message-ID: <1358077473.32505.10@driftwood> (raw)
In-Reply-To: <xa1tbocvby0s.fsf@mina86.com> (from mina86@mina86.com on Fri Jan 11 08:21:55 2013)

On 01/11/2013 08:21:55 AM, Michal Nazarewicz wrote:
> On Fri, Jan 11 2013, Minchan Kim <minchan@kernel.org> wrote:
> > The C standards allows the character type char to be singed or  
> unsinged,
> > depending on the platform and compiler. Most of systems uses signed  
> char,
> > but those based on PowerPC and ARM processors typically use  
> unsigned char.
> > This can lead to unexpected results when the variable is used to  
> compare
> > with EOF(-1). It happens my ARM system and this patch fixes it.
> >
> > Cc: Mel Gorman <mgorman@suse.de>
> > Cc: Andy Whitcroft <apw@shadowen.org>
> > Cc: Alexander Nyberg <alexn@dsv.su.se>
> > Cc: Michal Nazarewicz <mina86@mina86.com>
> 
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> >  Documentation/page_owner.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)

My kernel tree doesn't have Documentation/page_owner.c, where do I find  
this file?

Rob

  reply	other threads:[~2013-01-13 14:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  2:30 [PATCH v2 1/2] Fix wrong EOF compare Minchan Kim
2013-01-11  2:30 ` Minchan Kim
2013-01-11  2:30 ` [PATCH v2 2/2] Enhance read_block of page_owner.c Minchan Kim
2013-01-11  2:30   ` Minchan Kim
2013-01-11 16:01   ` Michal Nazarewicz
2013-01-11 16:01     ` Michal Nazarewicz
2013-01-14  2:33     ` Minchan Kim
2013-01-14  2:33       ` Minchan Kim
2013-01-14  8:27       ` Michal Nazarewicz
2013-01-11 14:21 ` [PATCH v2 1/2] Fix wrong EOF compare Michal Nazarewicz
2013-01-11 14:21   ` Michal Nazarewicz
2013-01-13 11:44   ` Rob Landley [this message]
2013-01-13 11:44     ` Rob Landley
2013-01-13 18:15     ` Randy Dunlap
2013-01-13 18:15       ` Randy Dunlap
2013-01-31 10:25       ` Rob Landley
2013-01-31 10:25         ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358077473.32505.10@driftwood \
    --to=rob@landley.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.orgMinchan \
    --cc=linux-mm@kvack.org \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.