All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] timer: vt8500: Move timer code to drivers/clocksource
Date: Tue, 15 Jan 2013 17:53:03 +1300	[thread overview]
Message-ID: <1358225583.5576.1.camel@gitbox> (raw)
In-Reply-To: <50F433A9.8020105@wwwdotorg.org>

On Mon, 2013-01-14 at 09:34 -0700, Stephen Warren wrote:
> On 01/13/2013 10:09 PM, Tony Prisk wrote:
> > This patch moves arch-vt8500/timer.c into drivers/clocksource and
> > updates the necessary Kconfig/Makefile options.
> 
> > diff --git a/include/linux/vt8500_timer.h b/include/linux/vt8500_timer.h
> 
> > +#ifndef __VT8500_TIMER_H
> > +#define __VT8500_TIMER_H
> > +
> > +#include <asm/mach/time.h>
> > +
> > +void vt8500_timer_init(void);
> > +
> > +#endif
> 
> Is VT8500 DT-only? If so, it'd be nice not to add this header, but
> instead use CLOCKSOURCE_OF_DECLARE() inside the driver C file.

Agreed - I didn't like the header when I added it but I didn't know of
another way and based in on the sunxi code.

Unfortunately Olof already pulled it into arm-soc, so I will try get
another patch done to undo it :)

Regards
Tony P

WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Olof Johansson <olof@lixom.net>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	vt8500-wm8505-linux-kernel@googlegroups.com, arm@kernel.org
Subject: Re: [PATCH] timer: vt8500: Move timer code to drivers/clocksource
Date: Tue, 15 Jan 2013 17:53:03 +1300	[thread overview]
Message-ID: <1358225583.5576.1.camel@gitbox> (raw)
In-Reply-To: <50F433A9.8020105@wwwdotorg.org>

On Mon, 2013-01-14 at 09:34 -0700, Stephen Warren wrote:
> On 01/13/2013 10:09 PM, Tony Prisk wrote:
> > This patch moves arch-vt8500/timer.c into drivers/clocksource and
> > updates the necessary Kconfig/Makefile options.
> 
> > diff --git a/include/linux/vt8500_timer.h b/include/linux/vt8500_timer.h
> 
> > +#ifndef __VT8500_TIMER_H
> > +#define __VT8500_TIMER_H
> > +
> > +#include <asm/mach/time.h>
> > +
> > +void vt8500_timer_init(void);
> > +
> > +#endif
> 
> Is VT8500 DT-only? If so, it'd be nice not to add this header, but
> instead use CLOCKSOURCE_OF_DECLARE() inside the driver C file.

Agreed - I didn't like the header when I added it but I didn't know of
another way and based in on the sunxi code.

Unfortunately Olof already pulled it into arm-soc, so I will try get
another patch done to undo it :)

Regards
Tony P


  reply	other threads:[~2013-01-15  4:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14  5:09 [GIT PULL] timer: vt8500: Move timer code to drivers/clocksource Tony Prisk
2013-01-14  5:09 ` Tony Prisk
2013-01-14  5:09 ` [PATCH] " Tony Prisk
2013-01-14  5:09   ` Tony Prisk
2013-01-14  5:13   ` [Bulk] " Tony Prisk
2013-01-14  5:13     ` Tony Prisk
2013-01-14  5:47     ` Tony Prisk
2013-01-14  5:47       ` Tony Prisk
2013-01-14  5:53       ` Tony Prisk
2013-01-14  5:53         ` Tony Prisk
2013-01-14 20:07       ` Olof Johansson
2013-01-14 20:07         ` Olof Johansson
2013-01-15  4:12         ` Tony Prisk
2013-01-15  4:12           ` Tony Prisk
2013-01-15  6:03           ` Olof Johansson
2013-01-15  6:03             ` Olof Johansson
2013-01-14 16:34   ` Stephen Warren
2013-01-14 16:34     ` Stephen Warren
2013-01-15  4:53     ` Tony Prisk [this message]
2013-01-15  4:53       ` Tony Prisk
2013-01-15  5:59       ` Olof Johansson
2013-01-15  5:59         ` Olof Johansson
2013-01-14 22:16 ` [GIT PULL] " Olof Johansson
2013-01-14 22:16   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358225583.5576.1.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.