From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed
Date: Tue, 15 Jan 2013 18:05:15 +1300 [thread overview]
Message-ID: <1358226315.5576.3.camel@gitbox> (raw)
In-Reply-To: <1358225886-5686-3-git-send-email-linux@prisktech.co.nz>
On Tue, 2013-01-15 at 17:58 +1300, Tony Prisk wrote:
> Memory mapped via ioremap call is never released. Rather than add an
> iounmap call, change allocation function to devm_request_and_ioremap.
>
> Also, change the error on failure for this call to -EBUSY rather than
> -EADDRNOTAVAIL.
Grr.. I thought I fixed this typo before I sent the patch.
I'll send another version but I'll wait for feedback on the series
first.
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: vt8500-wm8505-linux-kernel@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
Subject: Re: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed
Date: Tue, 15 Jan 2013 18:05:15 +1300 [thread overview]
Message-ID: <1358226315.5576.3.camel@gitbox> (raw)
In-Reply-To: <1358225886-5686-3-git-send-email-linux@prisktech.co.nz>
On Tue, 2013-01-15 at 17:58 +1300, Tony Prisk wrote:
> Memory mapped via ioremap call is never released. Rather than add an
> iounmap call, change allocation function to devm_request_and_ioremap.
>
> Also, change the error on failure for this call to -EBUSY rather than
> -EADDRNOTAVAIL.
Grr.. I thought I fixed this typo before I sent the patch.
I'll send another version but I'll wait for feedback on the series
first.
Regards
Tony P
next prev parent reply other threads:[~2013-01-15 5:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 4:58 [GIT PULL v2] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-15 4:58 ` Tony Prisk
2013-01-15 4:58 ` [PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports Tony Prisk
2013-01-15 4:58 ` Tony Prisk
2013-01-15 4:58 ` [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed Tony Prisk
2013-01-15 4:58 ` Tony Prisk
2013-01-15 5:05 ` Tony Prisk [this message]
2013-01-15 5:05 ` Tony Prisk
2013-01-16 13:29 ` Sergei Shtylyov
2013-01-16 13:29 ` Sergei Shtylyov
2013-01-15 4:58 ` [PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference Tony Prisk
2013-01-15 4:58 ` Tony Prisk
2013-01-15 4:58 ` [PATCH 4/4] serial: tty: Cleanup code using devm_ function Tony Prisk
2013-01-15 4:58 ` Tony Prisk
2013-01-16 6:57 ` Greg Kroah-Hartman
2013-01-16 6:57 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2013-01-14 2:04 [GIT PULL] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-14 2:04 ` [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed Tony Prisk
2013-01-14 2:04 ` Tony Prisk
2013-01-14 13:37 ` Sergei Shtylyov
2013-01-14 13:37 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358226315.5576.3.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.