* [PATCH v2] xen-netback: allow changing the MAC address of the interface
@ 2013-01-22 18:08 Matt Wilson
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Matt Wilson @ 2013-01-22 18:08 UTC (permalink / raw)
To: linux-kernel
Cc: Ian Campbell, Matt Wilson, netdev, xen-devel,
Konrad Rzeszutek Wilk
Sometimes it is useful to be able to change the MAC address of the
interface for netback devices. For example, when using ebtables it may
be useful to be able to distinguish traffic from different interfaces
without depending on the interface name.
Reported-by: Nikita Borzykh <sample.n@gmail.com>
Reported-by: Paul Harvey <stockingpaul@hotmail.com>
Cc: netdev@vger.kernel.org
Cc: xen-devel@lists.xen.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Matt Wilson <msw@amazon.com>
---
Changes since v1:
* No code changes, only updated commit message
---
drivers/net/xen-netback/interface.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index b7d41f8..f733cae 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
.ndo_stop = xenvif_close,
.ndo_change_mtu = xenvif_change_mtu,
.ndo_fix_features = xenvif_fix_features,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
--
1.7.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] xen-netback: allow changing the MAC address of the interface
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
@ 2013-01-22 20:21 ` Konrad Rzeszutek Wilk
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-01-22 20:21 UTC (permalink / raw)
To: Matt Wilson; +Cc: linux-kernel, Ian Campbell, netdev, xen-devel
On Tue, Jan 22, 2013 at 06:08:25PM +0000, Matt Wilson wrote:
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
>
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
>
> ---
> Changes since v1:
> * No code changes, only updated commit message
> ---
> drivers/net/xen-netback/interface.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index b7d41f8..f733cae 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
> .ndo_stop = xenvif_close,
> .ndo_change_mtu = xenvif_change_mtu,
> .ndo_fix_features = xenvif_fix_features,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> };
>
> struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
> --
> 1.7.4.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] xen-netback: allow changing the MAC address of the interface
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
@ 2013-01-22 20:21 ` Konrad Rzeszutek Wilk
2013-01-22 20:29 ` David Miller
2013-01-22 20:29 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-01-22 20:21 UTC (permalink / raw)
To: Matt Wilson; +Cc: netdev, xen-devel, linux-kernel, Ian Campbell
On Tue, Jan 22, 2013 at 06:08:25PM +0000, Matt Wilson wrote:
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
>
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
>
> ---
> Changes since v1:
> * No code changes, only updated commit message
> ---
> drivers/net/xen-netback/interface.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index b7d41f8..f733cae 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
> .ndo_stop = xenvif_close,
> .ndo_change_mtu = xenvif_change_mtu,
> .ndo_fix_features = xenvif_fix_features,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> };
>
> struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
> --
> 1.7.4.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] xen-netback: allow changing the MAC address of the interface
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
@ 2013-01-22 20:29 ` David Miller
2013-01-22 20:29 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-01-22 20:29 UTC (permalink / raw)
To: msw; +Cc: netdev, xen-devel, linux-kernel, konrad.wilk, ian.campbell
From: Matt Wilson <msw@amazon.com>
Date: Tue, 22 Jan 2013 18:08:25 +0000
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
>
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xen-netback: allow changing the MAC address of the interface
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
` (2 preceding siblings ...)
2013-01-22 20:29 ` David Miller
@ 2013-01-22 20:29 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-01-22 20:29 UTC (permalink / raw)
To: msw; +Cc: linux-kernel, ian.campbell, netdev, xen-devel, konrad.wilk
From: Matt Wilson <msw@amazon.com>
Date: Tue, 22 Jan 2013 18:08:25 +0000
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
>
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] xen-netback: allow changing the MAC address of the interface
@ 2013-01-22 18:08 Matt Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Matt Wilson @ 2013-01-22 18:08 UTC (permalink / raw)
To: linux-kernel
Cc: netdev, Konrad Rzeszutek Wilk, Ian Campbell, Matt Wilson,
xen-devel
Sometimes it is useful to be able to change the MAC address of the
interface for netback devices. For example, when using ebtables it may
be useful to be able to distinguish traffic from different interfaces
without depending on the interface name.
Reported-by: Nikita Borzykh <sample.n@gmail.com>
Reported-by: Paul Harvey <stockingpaul@hotmail.com>
Cc: netdev@vger.kernel.org
Cc: xen-devel@lists.xen.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Matt Wilson <msw@amazon.com>
---
Changes since v1:
* No code changes, only updated commit message
---
drivers/net/xen-netback/interface.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index b7d41f8..f733cae 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
.ndo_stop = xenvif_close,
.ndo_change_mtu = xenvif_change_mtu,
.ndo_fix_features = xenvif_fix_features,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
--
1.7.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-22 20:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
2013-01-22 20:21 ` Konrad Rzeszutek Wilk
2013-01-22 20:29 ` David Miller
2013-01-22 20:29 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-01-22 18:08 Matt Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.