[ath9k-devel] [PATCH 5/7] mac80211: Expand powersave configuration flag to be two bits

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:

> +static inline bool ieee80211_is_ps_disabled(struct ieee80211_conf *conf)

> +static inline bool ieee80211_is_ps_enabled(struct ieee80211_conf *conf)

Huh, is that worth the confusion? It seems !enabled should be the same
as disabled, but it's not quite the same, which might be confusing.

> +/**
> + * ieee80211_set_ps_state - set device powersave state
> + *
> + * Sets the powersave state in the supplied device configuration to the
> + * specified state.
> + *
> + * @conf: device configuration
> + * @state: new powersave state. Must be one of the IEEE80211_CONF_PS_*
> + *	flags from enum ieee80211_conf_flags.
> + */
> +static inline void ieee80211_set_ps_state(struct ieee80211_conf *conf,
> +					  u32 state)
> +{
> +	conf->flags = (conf->flags & ~IEEE80211_CONF_PS_MASK) |
> +		      (state & IEEE80211_CONF_PS_MASK);
> +}

I don't think the driver should do this, so the inline shouldn't be
here?

johannes