All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 8/8] KVM:PPC:booke: Allow debug interrupt injection to guest
Date: Thu, 31 Jan 2013 18:03:26 +0000	[thread overview]
Message-ID: <1359655406.31540.1@snotra> (raw)
In-Reply-To: <11819845-A3C0-41F1-90E3-8E22E97863CB@suse.de> (from agraf@suse.de on Thu Jan 31 06:04:29 2013)

On 01/31/2013 06:04:29 AM, Alexander Graf wrote:
> 
> On 30.01.2013, at 12:12, Bhushan Bharat-R65777 wrote:
> 
> > On bookehv this is how I am controlling the MSR_DE in hardware MSR.
> >
> >> And why is this whole thing only executed on HV?
> >
> > On e500v2 we always enable MSR_DE using vcpu->arch.shadow_msr in  
> e500.c
> > #ifndef CONFIG_KVM_BOOKE_HV
> > -       vcpu->arch.shadow_msr = MSR_USER | MSR_IS | MSR_DS;
> > +       vcpu->arch.shadow_msr = MSR_USER | MSR_DE | MSR_IS | MSR_DS;
> 
> Why? How is e500v2 any different wrt debug? And why wouldn't that  
> work for e500mc?

shadow_msr isn't used at all on bookehv.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 8/8] KVM:PPC:booke: Allow debug interrupt injection to guest
Date: Thu, 31 Jan 2013 12:03:26 -0600	[thread overview]
Message-ID: <1359655406.31540.1@snotra> (raw)
In-Reply-To: <11819845-A3C0-41F1-90E3-8E22E97863CB@suse.de> (from agraf@suse.de on Thu Jan 31 06:04:29 2013)

On 01/31/2013 06:04:29 AM, Alexander Graf wrote:
> 
> On 30.01.2013, at 12:12, Bhushan Bharat-R65777 wrote:
> 
> > On bookehv this is how I am controlling the MSR_DE in hardware MSR.
> >
> >> And why is this whole thing only executed on HV?
> >
> > On e500v2 we always enable MSR_DE using vcpu->arch.shadow_msr in  
> e500.c
> > #ifndef CONFIG_KVM_BOOKE_HV
> > -       vcpu->arch.shadow_msr = MSR_USER | MSR_IS | MSR_DS;
> > +       vcpu->arch.shadow_msr = MSR_USER | MSR_DE | MSR_IS | MSR_DS;
> 
> Why? How is e500v2 any different wrt debug? And why wouldn't that  
> work for e500mc?

shadow_msr isn't used at all on bookehv.

-Scott

  parent reply	other threads:[~2013-01-31 18:03 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  8:24 [PATCH 2/8] KVM: PPC: booke: Allow multiple exception types Bharat Bhushan
2013-01-16  8:36 ` Bharat Bhushan
2013-01-16  8:24 ` [PATCH 3/8] KVM: PPC: booke: Added debug handler Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-25 11:42   ` Alexander Graf
2013-01-25 11:42     ` Alexander Graf
2013-01-30 11:30     ` Bhushan Bharat-R65777
2013-01-31 12:17       ` Alexander Graf
2013-01-31 12:17         ` Alexander Graf
2013-01-31 16:58         ` Bhushan Bharat-R65777
2013-01-31 17:08           ` Alexander Graf
2013-01-31 17:08             ` Alexander Graf
2013-01-31 17:11             ` Alexander Graf
2013-01-31 17:11               ` Alexander Graf
2013-02-01  5:04             ` Bhushan Bharat-R65777
2013-02-01  5:04               ` Bhushan Bharat-R65777
2013-02-01  8:06               ` Alexander Graf
2013-02-01  8:06                 ` Alexander Graf
2013-02-01  9:07                 ` Bhushan Bharat-R65777
2013-02-01  9:07                   ` Bhushan Bharat-R65777
2013-02-07 14:21                   ` Alexander Graf
2013-02-07 14:21                     ` Alexander Graf
2013-02-07 14:48                     ` Bhushan Bharat-R65777
2013-02-07 14:48                       ` Bhushan Bharat-R65777
2013-02-07 15:01                       ` Alexander Graf
2013-02-07 15:01                         ` Alexander Graf
2013-01-16  8:24 ` [PATCH 4/8] Added ONE_REG interface for debug instruction Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-25 11:48   ` Alexander Graf
2013-01-25 11:48     ` Alexander Graf
2013-01-31 17:44     ` Bhushan Bharat-R65777
2013-01-31 17:52       ` Alexander Graf
2013-01-31 17:52         ` Alexander Graf
2013-01-31 17:58         ` Bhushan Bharat-R65777
2013-01-31 18:22           ` Alexander Graf
2013-01-31 18:22             ` Alexander Graf
2013-02-04  0:41   ` Paul Mackerras
2013-02-04  0:41     ` Paul Mackerras
2013-02-07 14:29     ` Alexander Graf
2013-02-07 14:29       ` Alexander Graf
2013-02-11  0:22       ` Paul Mackerras
2013-02-11  0:22         ` Paul Mackerras
2013-01-16  8:24 ` [PATCH 5/8] KVM: PPC: debug stub interface parameter defined Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-17  7:22   ` Paul Mackerras
2013-01-17  7:22     ` Paul Mackerras
2013-01-17 11:11     ` Bhushan Bharat-R65777
2013-01-25 11:53       ` Alexander Graf
2013-01-25 11:53         ` Alexander Graf
2013-01-30 14:15         ` Bhushan Bharat-R65777
2013-01-31 13:01           ` Alexander Graf
2013-01-31 13:01             ` Alexander Graf
2013-01-31 14:05             ` Bhushan Bharat-R65777
2013-01-31 14:27               ` Alexander Graf
2013-01-31 14:27                 ` Alexander Graf
2013-01-31 14:44                 ` Bhushan Bharat-R65777
2013-01-16  8:24 ` [PATCH 6/8] booke: Added DBCR4 SPR number Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-16  8:24 ` [PATCH 7/8] KVM: PPC: booke/bookehv: Add debug stub support Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-25 12:07   ` Alexander Graf
2013-01-25 12:07     ` Alexander Graf
2013-02-01  6:31     ` Bhushan Bharat-R65777
2013-02-01  6:31       ` Bhushan Bharat-R65777
2013-02-01  8:21       ` Alexander Graf
2013-02-01  8:21         ` Alexander Graf
2013-01-16  8:24 ` [PATCH 8/8] KVM:PPC:booke: Allow debug interrupt injection to guest Bharat Bhushan
2013-01-16  8:36   ` Bharat Bhushan
2013-01-25 12:13   ` Alexander Graf
2013-01-25 12:13     ` Alexander Graf
2013-01-30 11:12     ` Bhushan Bharat-R65777
2013-01-30 11:12       ` Bhushan Bharat-R65777
2013-01-31 12:04       ` Alexander Graf
2013-01-31 12:04         ` Alexander Graf
2013-01-31 17:59         ` Bhushan Bharat-R65777
2013-01-31 18:21           ` Alexander Graf
2013-01-31 18:21             ` Alexander Graf
2013-01-31 18:43             ` Scott Wood
2013-01-31 18:43               ` Scott Wood
2013-01-31 18:52               ` Alexander Graf
2013-01-31 18:52                 ` Alexander Graf
2013-01-31 18:54                 ` Scott Wood
2013-01-31 18:54                   ` Scott Wood
2013-01-31 19:05                   ` Alexander Graf
2013-01-31 19:05                     ` Alexander Graf
2013-01-31 19:20                     ` Alexander Graf
2013-01-31 19:20                       ` Alexander Graf
2013-01-31 22:40                       ` Scott Wood
2013-01-31 22:40                         ` Scott Wood
2013-02-01  0:11                         ` Alexander Graf
2013-02-01  0:11                           ` Alexander Graf
2013-02-01 22:38                           ` Scott Wood
2013-02-01 22:38                             ` Scott Wood
2013-02-04  4:48                             ` Bhushan Bharat-R65777
2013-02-04  4:48                               ` Bhushan Bharat-R65777
2013-02-04 19:47                               ` Scott Wood
2013-02-04 19:47                                 ` Scott Wood
2013-02-07 14:58                             ` Alexander Graf
2013-02-07 14:58                               ` Alexander Graf
2013-02-07 15:25                               ` Bhushan Bharat-R65777
2013-02-07 15:25                                 ` Bhushan Bharat-R65777
2013-02-07 15:53                                 ` Alexander Graf
2013-02-07 15:53                                   ` Alexander Graf
2013-02-07 15:00                             ` Bhushan Bharat-R65777
2013-02-07 15:00                               ` Bhushan Bharat-R65777
2013-02-07 15:08                               ` Alexander Graf
2013-02-07 15:08                                 ` Alexander Graf
2013-01-31 18:03         ` Scott Wood [this message]
2013-01-31 18:03           ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359655406.31540.1@snotra \
    --to=scottwood@freescale.com \
    --cc=R65777@freescale.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.