Re: [PATCH BlueZ] AVRCP: Handler player features as a byte array

[Marcel Holtmann <marcel@holtmann.org>]

Hi Luiz,

> >> --- a/profiles/audio/player.c
> >> +++ b/profiles/audio/player.c
> >> @@ -67,7 +67,7 @@ struct media_player {
> >>       char                    *name;          /* Player name */
> >>       char                    *type;          /* Player type */
> >>       char                    *subtype;       /* Player subtype */
> >> -     uint64_t                features[2];    /* Player features */
> >> +     uint8_t                 *features;      /* Player features */
> >
> > Why not just have this as features[16] here as well so you don't need to
> > do g_memdup and g_free?
> 
> I was planning to have a NULL check if the features are valid.

actually I like to decrease the number of extra memory allocations. So
what benefit is the test for features giving you actually.

Regards

Marcel