From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] AVRCP: Handler player features as a byte array
Date: Mon, 4 Feb 2013 10:30:30 +0200 [thread overview]
Message-ID: <20130204083030.GA1147@x220> (raw)
In-Reply-To: <1359924910-27167-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Sun, Feb 03, 2013, Luiz Augusto von Dentz wrote:
> --- a/profiles/audio/player.c
> +++ b/profiles/audio/player.c
> @@ -67,7 +67,7 @@ struct media_player {
> char *name; /* Player name */
> char *type; /* Player type */
> char *subtype; /* Player subtype */
> - uint64_t features[2]; /* Player features */
> + uint8_t *features; /* Player features */
Why not just have this as features[16] here as well so you don't need to
do g_memdup and g_free?
Johan
next prev parent reply other threads:[~2013-02-04 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 20:55 [PATCH BlueZ] AVRCP: Handler player features as a byte array Luiz Augusto von Dentz
2013-02-04 8:30 ` Johan Hedberg [this message]
2013-02-04 8:34 ` Luiz Augusto von Dentz
2013-02-04 9:27 ` Marcel Holtmann
2013-02-04 9:42 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204083030.GA1147@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.