From: Kukjin Kim <kgene@kernel.org>
To: 'Leela Krishna Amudala' <l.krishna@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: inki.dae@samsung.com, jg1.han@samsung.com, thomas.abraham@linaro.org
Subject: RE: [PATCH V2 3/3] ARM: EXYNOS: Add drm-device node to the dtsi file
Date: Wed, 26 Sep 2012 10:46:01 +0900 [thread overview]
Message-ID: <135e01cd9b88$aea81140$0bf833c0$@org> (raw)
In-Reply-To: <1348232397-2477-4-git-send-email-l.krishna@samsung.com>
Leela Krishna Amudala wrote:
>
> This patch adds platform drm-device node to the dtsi file
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 6401c94..f0cc06d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -495,4 +495,8 @@
> reg = <0x14400000 0x40000>;
> interrupts = <18 5>, <18 4>, <18 6>;
> };
> +
> + drm-device {
> + compatible = "samsung,exynos-drm-device";
> + };
> };
> --
Please check below comments from Thomas Abraham and I agree with his
opinion.
There cannot be a node that represents a virtual device. Device tree should
ideally describe the hardware but the above node does not represent a
hardware device. The creation of the platform device instance for the above
device should handled inside the kernel code.
Thanks.
K-Gene <kgene@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] ARM: EXYNOS: Add drm-device node to the dtsi file
Date: Wed, 26 Sep 2012 10:46:01 +0900 [thread overview]
Message-ID: <135e01cd9b88$aea81140$0bf833c0$@org> (raw)
In-Reply-To: <1348232397-2477-4-git-send-email-l.krishna@samsung.com>
Leela Krishna Amudala wrote:
>
> This patch adds platform drm-device node to the dtsi file
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 6401c94..f0cc06d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -495,4 +495,8 @@
> reg = <0x14400000 0x40000>;
> interrupts = <18 5>, <18 4>, <18 6>;
> };
> +
> + drm-device {
> + compatible = "samsung,exynos-drm-device";
> + };
> };
> --
Please check below comments from Thomas Abraham and I agree with his
opinion.
There cannot be a node that represents a virtual device. Device tree should
ideally describe the hardware but the above node does not represent a
hardware device. The creation of the platform device instance for the above
device should handled inside the kernel code.
Thanks.
K-Gene <kgene@kernel.org>
next prev parent reply other threads:[~2012-09-26 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 12:59 [PATCH V2 0/3] Add device tree based discovery support for drm-fimd Leela Krishna Amudala
2012-09-21 12:59 ` Leela Krishna Amudala
2012-09-21 12:59 ` [PATCH V2 1/3] ARM: EXYNOS5: Add fimd node to the exynos5250 dtsi file Leela Krishna Amudala
2012-09-21 12:59 ` Leela Krishna Amudala
2012-09-21 12:59 ` [PATCH V2 2/3] ARM: EXYNOS: add device tree based discovery support for FIMD Leela Krishna Amudala
2012-09-21 12:59 ` Leela Krishna Amudala
2012-09-21 12:59 ` [PATCH V2 3/3] ARM: EXYNOS: Add drm-device node to the dtsi file Leela Krishna Amudala
2012-09-21 12:59 ` Leela Krishna Amudala
2012-09-26 1:46 ` Kukjin Kim [this message]
2012-09-26 1:46 ` Kukjin Kim
2012-09-28 6:51 ` Tomasz Figa
2012-09-28 6:51 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='135e01cd9b88$aea81140$0bf833c0$@org' \
--to=kgene@kernel.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.