From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: David Vrabel <dvrabel@cantab.net>,
Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: netback Oops then xenwatch stuck in D state
Date: Thu, 14 Feb 2013 11:34:23 +0000 [thread overview]
Message-ID: <1360841663.20449.345.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1360840843.16636.109.camel@zion.uk.xensource.com>
On Thu, 2013-02-14 at 11:20 +0000, Wei Liu wrote:
> I'm not convinced. netbk_tx_err only has one xenvif_put, however
> netbk_fatal_tx_err has two puts.
One balances the get in poll_net_schedule_list (i.e. at the top of the
loop in xen_netbk_tx_build_gops.
The other one I guess you mean the one in xenvif_carrier_off? This
balances the refcount taken in xenvif_connect, when the carrier is
brought up.
In my testing I found that both were required or else things deadlock in
xenvif_disconnect with the refcnt stuck at 1.
The eventual put in xenvif_disconnect is balanced by the initial count
of 1 in xenvif_alloc()
Ian.
> If this is a bug, and, if my previous patch fixes Christopher's OOPS, he
> will hit this bug soon when shutting down DomU.
>
>
> Wei.
>
next prev parent reply other threads:[~2013-02-14 11:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 21:58 netback Oops then xenwatch stuck in D state Christopher S. Aker
2013-02-01 22:14 ` Andrew Cooper
2013-02-02 1:01 ` Wei Liu
2013-02-04 16:12 ` Christopher S. Aker
2013-02-04 17:37 ` Wei Liu
2013-02-10 5:30 ` Christopher S. Aker
2013-02-10 22:03 ` Christopher S. Aker
2013-02-11 11:45 ` Wei Liu
2013-02-11 16:17 ` Christopher S. Aker
2013-02-11 16:57 ` Wei Liu
2013-02-11 18:44 ` Christopher S. Aker
2013-02-12 14:59 ` Wei Liu
2013-02-12 9:58 ` Ian Campbell
2013-02-13 2:51 ` Christopher S. Aker
2013-02-13 12:47 ` Wei Liu
2013-02-13 20:12 ` Christopher S. Aker
2013-02-13 20:29 ` Wei Liu
2013-02-13 16:40 ` Jan Beulich
2013-02-13 18:24 ` Wei Liu
2013-02-13 18:37 ` Wei Liu
2013-02-13 19:20 ` David Vrabel
2013-02-13 19:39 ` Wei Liu
2013-02-13 20:17 ` Wei Liu
2013-02-14 9:11 ` Jan Beulich
2013-02-14 11:20 ` Wei Liu
2013-02-14 11:34 ` Ian Campbell [this message]
2013-02-14 11:38 ` Wei Liu
2013-02-14 11:50 ` Jan Beulich
2013-02-14 11:56 ` Wei Liu
2013-02-14 11:48 ` Jan Beulich
2013-02-14 12:13 ` Wei Liu
2013-02-14 12:33 ` Jan Beulich
2013-02-14 12:40 ` Wei Liu
2013-02-14 12:45 ` Jan Beulich
2013-02-14 15:29 ` Jan Beulich
2013-02-14 15:38 ` Wei Liu
2013-02-14 12:20 ` David Vrabel
2013-02-14 12:29 ` Wei Liu
2013-02-14 12:38 ` Ian Campbell
2013-02-14 12:47 ` David Vrabel
2013-02-14 12:55 ` Wei Liu
2013-02-14 12:39 ` Jan Beulich
2013-02-14 11:25 ` David Vrabel
2013-02-14 9:14 ` Jan Beulich
2013-02-14 9:25 ` Jan Beulich
2013-02-14 10:57 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360841663.20449.345.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=dvrabel@cantab.net \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.