All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <dvrabel@cantab.net>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: netback Oops then xenwatch stuck in D state
Date: Thu, 14 Feb 2013 11:25:09 +0000	[thread overview]
Message-ID: <511CC995.6050709@cantab.net> (raw)
In-Reply-To: <511CB86702000078000BE1C5@nat28.tlf.novell.com>

On 14/02/13 09:11, Jan Beulich wrote:
>
> I first thought so too when looking at this again yesterday, but
> then convinced myself that this double put _here_ is correct. And
> Ian's patch specifically removed to call to netbk_tx_err() after the
> caller netbk_count_requests() recognized the error, knowing that
> the latter function now itself issues a call to netbk_fatal_tx_err()
> (whether that wouldn't better have replaced the caller's call to
> netbk_tx_err() is a different question).

Yes, I agree.  I had too many different versions of netback open and got
confused.

David

  parent reply	other threads:[~2013-02-14 11:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 21:58 netback Oops then xenwatch stuck in D state Christopher S. Aker
2013-02-01 22:14 ` Andrew Cooper
2013-02-02  1:01 ` Wei Liu
2013-02-04 16:12   ` Christopher S. Aker
2013-02-04 17:37     ` Wei Liu
2013-02-10  5:30   ` Christopher S. Aker
2013-02-10 22:03     ` Christopher S. Aker
2013-02-11 11:45       ` Wei Liu
2013-02-11 16:17         ` Christopher S. Aker
2013-02-11 16:57           ` Wei Liu
2013-02-11 18:44             ` Christopher S. Aker
2013-02-12 14:59               ` Wei Liu
2013-02-12  9:58         ` Ian Campbell
2013-02-13  2:51           ` Christopher S. Aker
2013-02-13 12:47             ` Wei Liu
2013-02-13 20:12               ` Christopher S. Aker
2013-02-13 20:29                 ` Wei Liu
2013-02-13 16:40             ` Jan Beulich
2013-02-13 18:24             ` Wei Liu
2013-02-13 18:37               ` Wei Liu
2013-02-13 19:20                 ` David Vrabel
2013-02-13 19:39                   ` Wei Liu
2013-02-13 20:17                   ` Wei Liu
2013-02-14  9:11                     ` Jan Beulich
2013-02-14 11:20                       ` Wei Liu
2013-02-14 11:34                         ` Ian Campbell
2013-02-14 11:38                           ` Wei Liu
2013-02-14 11:50                             ` Jan Beulich
2013-02-14 11:56                               ` Wei Liu
2013-02-14 11:48                         ` Jan Beulich
2013-02-14 12:13                           ` Wei Liu
2013-02-14 12:33                             ` Jan Beulich
2013-02-14 12:40                               ` Wei Liu
2013-02-14 12:45                               ` Jan Beulich
2013-02-14 15:29                                 ` Jan Beulich
2013-02-14 15:38                                   ` Wei Liu
2013-02-14 12:20                           ` David Vrabel
2013-02-14 12:29                             ` Wei Liu
2013-02-14 12:38                               ` Ian Campbell
2013-02-14 12:47                               ` David Vrabel
2013-02-14 12:55                                 ` Wei Liu
2013-02-14 12:39                             ` Jan Beulich
2013-02-14 11:25                       ` David Vrabel [this message]
2013-02-14  9:14                 ` Jan Beulich
2013-02-14  9:25                   ` Jan Beulich
2013-02-14 10:57                   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511CC995.6050709@cantab.net \
    --to=dvrabel@cantab.net \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.