From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
Date: Sun, 17 Feb 2013 07:47:24 +0000 [thread overview]
Message-ID: <1361087244.31795.105.camel@ted> (raw)
In-Reply-To: <1361049644-27904-2-git-send-email-otavio@ossystems.com.br>
On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-core/dbus/dbus.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 292ab29..cebab28 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> X11DEPENDS = "virtual/libx11 libsm"
> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> DEPENDS_class-native = "expat-native virtual/libintl-native"
> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> RDEPENDS_class-native = ""
This tends to be a really bad idea for dbus-nativesdk. If you install an
SDK compiled with these options into PATH only a system which does have
x11, it will break functionality in a way unacceptable to users.
I'm not sure we should ever ship dbus-launch with the SDK so perhaps we
should just delete it like we now do for the -native version, then we
could drop the x11 requirement in all cases.
Cheers,
Richard
next prev parent reply other threads:[~2013-02-17 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2013-02-17 7:47 ` Richard Purdie [this message]
2013-02-17 13:40 ` Otavio Salvador
2013-02-17 13:44 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
2013-02-17 14:48 ` Richard Purdie
2013-02-17 14:52 ` Otavio Salvador
2013-02-17 15:10 ` Richard Purdie
2013-02-17 15:31 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
2013-02-17 7:52 ` Richard Purdie
2013-02-17 13:42 ` Otavio Salvador
2013-02-17 13:46 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361087244.31795.105.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.