From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
Date: Sun, 17 Feb 2013 13:46:20 +0000 [thread overview]
Message-ID: <1361108780.32271.3.camel@ted> (raw)
In-Reply-To: <CAP9ODKqd_DbKPHu_FYnHAR2TRqb8Ouw3XuonR43P6Ze0zT9qRQ@mail.gmail.com>
On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> index e25c597..3dbe97a 100644
> >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
> >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
> >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
> >> tslib"
> >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
> >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
> >
> > Don't you mean virtual/nativesdk-libx11 ?
>
> Other places are using virtual/libx11 so I sticked to it.
Other places in nativesdk overrides?
> For me it
> has worked but I did not change if it'd choose the right package when
> building with 'x11' (as my project now builds without it).
That doesn't make it correct.
Cheers,
Richard
next prev parent reply other threads:[~2013-02-17 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2013-02-17 7:47 ` Richard Purdie
2013-02-17 13:40 ` Otavio Salvador
2013-02-17 13:44 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
2013-02-17 14:48 ` Richard Purdie
2013-02-17 14:52 ` Otavio Salvador
2013-02-17 15:10 ` Richard Purdie
2013-02-17 15:31 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
2013-02-17 7:52 ` Richard Purdie
2013-02-17 13:42 ` Otavio Salvador
2013-02-17 13:46 ` Richard Purdie [this message]
2013-02-17 13:55 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361108780.32271.3.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.