All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 3/9] video: sysfb: always provide vbefb device
Date: Sun, 17 Feb 2013 17:59:05 +0000	[thread overview]
Message-ID: <1361123951-587-4-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1361123951-587-1-git-send-email-dh.herrmann@gmail.com>

From: David Herrmann <dh.herrmann@googlemail.com>

HACK: This should be provided by architecture setup code. But to show how it is
supposed to work, we now simply add a "vbefb" device during initialization.

The better way to do this is by moving this into arch-code. So for instance the
x86 boot initialization should create this platform-device after VBE/VESA screen
detection. Other architectures can do the same or introduce other framebuffer
types than SYSFB_VBE.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/video/sysfb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/sysfb.c b/drivers/video/sysfb.c
index 5b47a9a..0c0a4e7 100644
--- a/drivers/video/sysfb.c
+++ b/drivers/video/sysfb.c
@@ -271,6 +271,8 @@ static struct platform_driver sysfb_vbe_driver = {
 	.remove = sysfb_vbe_remove,
 };
 
+static struct platform_device *sysfb_vbe_device;
+
 static int __init sysfb_init(void)
 {
 	int ret;
@@ -287,6 +289,12 @@ static int __init sysfb_init(void)
 		goto err_bus;
 	}
 
+	sysfb_vbe_device = platform_device_register_data(NULL, "vbefb", -1,
+							 &screen_info,
+							 sizeof(screen_info));
+	if (!sysfb_vbe_device)
+		pr_warn("cannot create vbefb device\n");
+
 	return 0;
 
 err_bus:
-- 
1.8.1.3


WARNING: multiple messages have this Message-ID (diff)
From: David Herrmann <dh.herrmann@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH 3/9] video: sysfb: always provide vbefb device
Date: Sun, 17 Feb 2013 18:59:05 +0100	[thread overview]
Message-ID: <1361123951-587-4-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1361123951-587-1-git-send-email-dh.herrmann@gmail.com>

From: David Herrmann <dh.herrmann@googlemail.com>

HACK: This should be provided by architecture setup code. But to show how it is
supposed to work, we now simply add a "vbefb" device during initialization.

The better way to do this is by moving this into arch-code. So for instance the
x86 boot initialization should create this platform-device after VBE/VESA screen
detection. Other architectures can do the same or introduce other framebuffer
types than SYSFB_VBE.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/video/sysfb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/sysfb.c b/drivers/video/sysfb.c
index 5b47a9a..0c0a4e7 100644
--- a/drivers/video/sysfb.c
+++ b/drivers/video/sysfb.c
@@ -271,6 +271,8 @@ static struct platform_driver sysfb_vbe_driver = {
 	.remove = sysfb_vbe_remove,
 };
 
+static struct platform_device *sysfb_vbe_device;
+
 static int __init sysfb_init(void)
 {
 	int ret;
@@ -287,6 +289,12 @@ static int __init sysfb_init(void)
 		goto err_bus;
 	}
 
+	sysfb_vbe_device = platform_device_register_data(NULL, "vbefb", -1,
+							 &screen_info,
+							 sizeof(screen_info));
+	if (!sysfb_vbe_device)
+		pr_warn("cannot create vbefb device\n");
+
 	return 0;
 
 err_bus:
-- 
1.8.1.3

  parent reply	other threads:[~2013-02-17 17:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-17 17:59 [PATCH 0/9] System Framebuffer Bus (sysfb) David Herrmann
2013-02-17 17:59 ` David Herrmann
2013-02-17 17:59 ` [PATCH 1/9] video: introduce system framebuffer bus David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 2/9] video: sysfb: new vbefb device type David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` David Herrmann [this message]
2013-02-17 17:59   ` [PATCH 3/9] video: sysfb: always provide vbefb device David Herrmann
2013-02-17 17:59 ` [PATCH 4/9] video: vesafb: allow building as module David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 5/9] video: vesafb: use sysfb bus David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 6/9] drm: new sysfb DRM bus module David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 7/9] drm: new VESA BIOS Extension DRM driver stub David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 8/9] drm: dvbe: implement VBE/VESA blitting backend David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 17:59 ` [PATCH 9/9] drm: dvbe: add optional fbdev frontend David Herrmann
2013-02-17 17:59   ` David Herrmann
2013-02-17 22:02 ` [PATCH 0/9] System Framebuffer Bus (sysfb) Dave Airlie
2013-02-17 22:02   ` Dave Airlie
2013-02-17 22:02   ` Dave Airlie
2013-02-17 23:35   ` David Herrmann
2013-02-17 23:35     ` David Herrmann
2013-02-17 23:35     ` David Herrmann
2013-02-17 23:47     ` Dave Airlie
2013-02-17 23:47       ` Dave Airlie
2013-02-28 12:20       ` David Herrmann
2013-02-28 12:20         ` David Herrmann
2013-02-28 13:22         ` Geert Uytterhoeven
2013-02-28 13:22           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361123951-587-4-git-send-email-dh.herrmann@gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=airlied@linux.ie \
    --cc=dh.herrmann@googlemail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.