All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/2] mac80211: disconnect on suspend in managed mode
Date: Wed, 20 Feb 2013 11:06:44 +0100	[thread overview]
Message-ID: <1361354804.8629.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130219164714.GA27140@redhat.com>

On Tue, 2013-02-19 at 17:47 +0100, Stanislaw Gruszka wrote:
> If possible that after suspend cfg80211 receive request to disconnect
> what require action on interface that was removed during suspend.
> Problem can manifest itself by various warnings similar to below one:
[...]
> To fix the problem disconnect from AP during suspend.

This will fix the immediate problem, but not in general. What if we're
joined to an IBSS while suspending? A similar thing could happen. Or
operating as an AP? Or joined to a mesh? etc.

I think it'd be better to implement this as explicit disconnect, leave,
teardown, whatever ... in cfg80211 rather than mac80211, although then
of course mac80211 could have a bunch of cleanups, e.g. the various
_quiesce functions could be reduced then I think.

johannes


  parent reply	other threads:[~2013-02-20 10:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 16:47 [RFC 1/2] mac80211: disconnect on suspend in managed mode Stanislaw Gruszka
2013-02-19 16:48 ` [RFC 2/2] mac80211: sync suspend and stop interface Stanislaw Gruszka
2013-02-20 10:08   ` Johannes Berg
2013-02-20 10:06 ` Johannes Berg [this message]
2013-02-21 10:29   ` [RFC 1/2] mac80211: disconnect on suspend in managed mode Stanislaw Gruszka
2013-02-22 20:31     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361354804.8629.15.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.