All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/2] mac80211: disconnect on suspend in managed mode
Date: Fri, 22 Feb 2013 21:31:01 +0100	[thread overview]
Message-ID: <1361565061.3420.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130221102939.GA19443@redhat.com>

On Thu, 2013-02-21 at 11:29 +0100, Stanislaw Gruszka wrote:

> --- a/net/wireless/sysfs.c
> +++ b/net/wireless/sysfs.c
> @@ -86,16 +86,21 @@ static int wiphy_uevent(struct device *dev, struct kobj_uevent_env *env)
>  static int wiphy_suspend(struct device *dev, pm_message_t state)
>  {
>  	struct cfg80211_registered_device *rdev = dev_to_rdev(dev);
> +	struct wireless_dev *wdev;
>  	int ret = 0;
>  
>  	rdev->suspend_at = get_seconds();
>  
> -	if (rdev->ops->suspend) {
> -		rtnl_lock();
> -		if (rdev->wiphy.registered)
> +	rtnl_lock();
> +	if (rdev->wiphy.registered) {
> +		list_for_each_entry_rcu(wdev, &rdev->wdev_list, list)
> +			cfg80211_leave(rdev, wdev);
> +
> +		if (rdev->ops->suspend)
>  			ret = rdev_suspend(rdev);

I think this would break WoWLAN?

johannes


      reply	other threads:[~2013-02-22 20:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 16:47 [RFC 1/2] mac80211: disconnect on suspend in managed mode Stanislaw Gruszka
2013-02-19 16:48 ` [RFC 2/2] mac80211: sync suspend and stop interface Stanislaw Gruszka
2013-02-20 10:08   ` Johannes Berg
2013-02-20 10:06 ` [RFC 1/2] mac80211: disconnect on suspend in managed mode Johannes Berg
2013-02-21 10:29   ` Stanislaw Gruszka
2013-02-22 20:31     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361565061.3420.13.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.