[PULL] SH Mobile DRM driver for v3.7

[PULL] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

Hi Dave,

The SH Mobile DRM driver is now (in my opinion) ready for mainline. It 
requires GEM and KMS/FB helpers that have been reviewed on the list and 
tested. Sascha is waiting for them to reach your tree to send a pull request 
for another new driver.

The following changes since commit 09e7dcf081b1100d1cdff57fa9eb25c3a834c9d6:

  gma500: Remove unused variable (2012-09-13 11:40:05 +1000)

are available in the git repository at:
  git://linuxtv.org/pinchartl/fbdev.git drm-lcdc

Lars-Peter Clausen (1):
      DRM: Add DRM KMS/FB CMA helper

Laurent Pinchart (2):
      drm: Add NV24 and NV42 pixel formats
      drm: Renesas SH Mobile DRM driver

Sascha Hauer (1):
      DRM: Add DRM GEM CMA helper

 drivers/gpu/drm/Kconfig                        |   17 +
 drivers/gpu/drm/Makefile                       |    3 +
 drivers/gpu/drm/drm_crtc.c                     |    6 +
 drivers/gpu/drm/drm_fb_cma_helper.c            |  406 +++++++++++++
 drivers/gpu/drm/drm_gem_cma_helper.c           |  251 ++++++++
 drivers/gpu/drm/shmobile/Kconfig               |   10 +
 drivers/gpu/drm/shmobile/Makefile              |    7 +
 drivers/gpu/drm/shmobile/shmob_drm_backlight.c |   90 +++
 drivers/gpu/drm/shmobile/shmob_drm_backlight.h |   23 +
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c      |  763 +++++++++++++++++++++++
 drivers/gpu/drm/shmobile/shmob_drm_crtc.h      |   60 ++
 drivers/gpu/drm/shmobile/shmob_drm_drv.c       |  361 +++++++++++
 drivers/gpu/drm/shmobile/shmob_drm_drv.h       |   48 ++
 drivers/gpu/drm/shmobile/shmob_drm_kms.c       |  160 +++++
 drivers/gpu/drm/shmobile/shmob_drm_kms.h       |   34 +
 drivers/gpu/drm/shmobile/shmob_drm_plane.c     |  268 +++++++++
 drivers/gpu/drm/shmobile/shmob_drm_plane.h     |   22 +
 drivers/gpu/drm/shmobile/shmob_drm_regs.h      |  311 ++++++++++
 include/drm/drm_fb_cma_helper.h                |   27 +
 include/drm/drm_fourcc.h                       |    2 +
 include/drm/drm_gem_cma_helper.h               |   44 ++
 include/drm/shmob_drm.h                        |   99 +++
 22 files changed, 3012 insertions(+), 0 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fb_cma_helper.c
 create mode 100644 drivers/gpu/drm/drm_gem_cma_helper.c
 create mode 100644 drivers/gpu/drm/shmobile/Kconfig
 create mode 100644 drivers/gpu/drm/shmobile/Makefile
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h
 create mode 100644 include/drm/drm_fb_cma_helper.h
 create mode 100644 include/drm/drm_gem_cma_helper.h
 create mode 100644 include/drm/shmob_drm.h

-- 
Regards,

Laurent Pinchart

Re: [PULL] SH Mobile DRM driver for v3.7

[Alan Cox]

On Fri, 14 Sep 2012 14:38:10 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Dave,
> 
> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It 
> requires GEM and KMS/FB helpers that have been reviewed on the list and 
> tested. Sascha is waiting for them to reach your tree to send a pull request 
> for another new driver.
> 
> The following changes since commit 09e7dcf081b1100d1cdff57fa9eb25c3a834c9d6:
> 
>   gma500: Remove unused variable (2012-09-13 11:40:05 +1000)
> 
> are available in the git repository at:
>   git://linuxtv.org/pinchartl/fbdev.git drm-lcdc

Wrong summary ??

Re: [PULL] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

Hi Alan,

On Friday 14 September 2012 13:47:33 Alan Cox wrote:
> On Fri, 14 Sep 2012 14:38:10 +0200 Laurent Pinchart wrote:
> > Hi Dave,
> > 
> > The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> > requires GEM and KMS/FB helpers that have been reviewed on the list and
> > tested. Sascha is waiting for them to reach your tree to send a pull
> > request for another new driver.
> > 
> > The following changes since commit 
09e7dcf081b1100d1cdff57fa9eb25c3a834c9d6:
> >   gma500: Remove unused variable (2012-09-13 11:40:05 +1000)
> > 
> > are available in the git repository at:
> >   git://linuxtv.org/pinchartl/fbdev.git drm-lcdc
> 
> Wrong summary ??

The repository is oddly named because I've initially created it to hold fbdev 
patches. The drm-lcdc branch contains DRM patches.

-- 
Regards,

Laurent Pinchart

Re: [PULL] SH Mobile DRM driver for v3.7

[Alan Cox]

On Fri, 14 Sep 2012 15:05:44 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Alan,
> 
> On Friday 14 September 2012 13:47:33 Alan Cox wrote:
> > On Fri, 14 Sep 2012 14:38:10 +0200 Laurent Pinchart wrote:
> > > Hi Dave,
> > > 
> > > The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> > > requires GEM and KMS/FB helpers that have been reviewed on the list and
> > > tested. Sascha is waiting for them to reach your tree to send a pull
> > > request for another new driver.
> > > 
> > > The following changes since commit 
> 09e7dcf081b1100d1cdff57fa9eb25c3a834c9d6:
> > >   gma500: Remove unused variable (2012-09-13 11:40:05 +1000)
> > > 
> > > are available in the git repository at:
> > >   git://linuxtv.org/pinchartl/fbdev.git drm-lcdc
> > 
> > Wrong summary ??
> 
> The repository is oddly named because I've initially created it to hold fbdev 
> patches. The drm-lcdc branch contains DRM patches.

Yeah but the only change in it is a gma500 change not an SH one !

> 

Re: [PULL] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

Hi Alan,

On Friday 14 September 2012 23:57:57 Alan Cox wrote:
> On Fri, 14 Sep 2012 15:05:44 +0200
> 
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> > Hi Alan,
> > 
> > On Friday 14 September 2012 13:47:33 Alan Cox wrote:
> > > On Fri, 14 Sep 2012 14:38:10 +0200 Laurent Pinchart wrote:
> > > > Hi Dave,
> > > > 
> > > > The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> > > > requires GEM and KMS/FB helpers that have been reviewed on the list
> > > > and tested. Sascha is waiting for them to reach your tree to send a
> > > > pull request for another new driver.
> > > > 
> > > > The following changes since commit
> > 
> > 09e7dcf081b1100d1cdff57fa9eb25c3a834c9d6:
> > > >   gma500: Remove unused variable (2012-09-13 11:40:05 +1000)
> > > > 
> > > > are available in the git repository at:
> > > >   git://linuxtv.org/pinchartl/fbdev.git drm-lcdc
> > > 
> > > Wrong summary ??
> > 
> > The repository is oddly named because I've initially created it to hold
> > fbdev patches. The drm-lcdc branch contains DRM patches.
> 
> Yeah but the only change in it is a gma500 change not an SH one !

I'll assume you need a cup of coffee ;-) Please reread the original mail, 
there are 4 changes *since* the gma500 commit.

-- 
Regards,

Laurent Pinchart

Re: [PULL] SH Mobile DRM driver for v3.7

[Dave Airlie]

On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Dave,
>
> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> requires GEM and KMS/FB helpers that have been reviewed on the list and
> tested. Sascha is waiting for them to reach your tree to send a pull request
> for another new driver.

Just a quick review before I pull,

Why does include/drm/shmob_drm.h exist? this file is meant to define
the userspace API to the driver, if you don't have any userspace API
or driver specific ioctls, this file shouldn't be required. You might
want to create include/drm/shmob_internal.h maybe, if this is used as
an interface to other places in the kernel. I probably need to check
other have been doing the right thing here as well. (driver_drm.h
should be user facing only)

Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
no driver is ever going to want to tweak the drm_fbdev_cma_ops?
really? you are forcing the driver into a corner, drivers call into
helpers, midlayers call into drivers or block them from being called.
you should probably at least change it so the fb_ops are passed into
drm_fbdev_cma_create.

Dave.

Re: [PULL] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

Hi Dave,

On Saturday 15 September 2012 09:28:14 Dave Airlie wrote:
> On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart wrote:
> > Hi Dave,
> > 
> > The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> > requires GEM and KMS/FB helpers that have been reviewed on the list and
> > tested. Sascha is waiting for them to reach your tree to send a pull
> > request for another new driver.
> 
> Just a quick review before I pull,
> 
> Why does include/drm/shmob_drm.h exist? this file is meant to define
> the userspace API to the driver, if you don't have any userspace API
> or driver specific ioctls, this file shouldn't be required. You might
> want to create include/drm/shmob_internal.h maybe, if this is used as
> an interface to other places in the kernel. I probably need to check
> other have been doing the right thing here as well. (driver_drm.h
> should be user facing only)

The file contains platform data. I can move it to include/linux/platform_data/

> Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
> no driver is ever going to want to tweak the drm_fbdev_cma_ops?
> really? you are forcing the driver into a corner, drivers call into
> helpers, midlayers call into drivers or block them from being called.
> you should probably at least change it so the fb_ops are passed into
> drm_fbdev_cma_create.

I'll let Lars answer that.

-- 
Regards,

Laurent Pinchart

Re: [PULL] SH Mobile DRM driver for v3.7

[Lars-Peter Clausen]

On 09/15/2012 01:28 AM, Dave Airlie wrote:
> On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
>> Hi Dave,
>>
>> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
>> requires GEM and KMS/FB helpers that have been reviewed on the list and
>> tested. Sascha is waiting for them to reach your tree to send a pull request
>> for another new driver.
> 
> Just a quick review before I pull,
> 
> Why does include/drm/shmob_drm.h exist? this file is meant to define
> the userspace API to the driver, if you don't have any userspace API
> or driver specific ioctls, this file shouldn't be required. You might
> want to create include/drm/shmob_internal.h maybe, if this is used as
> an interface to other places in the kernel. I probably need to check
> other have been doing the right thing here as well. (driver_drm.h
> should be user facing only)
> 
> Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
> no driver is ever going to want to tweak the drm_fbdev_cma_ops?

Obviously we can't, for the same reasons we can't know whether there will ever
be a driver which needs to use custom fb_ops. It works fine as it is now for
three different drivers. And other drivers making use of the cma buffer helpers
are likely to have similar requirements, but if we ever get to a point where a
driver needs custom fb_ops it is fairly easy to change it then.

- Lars

Re: [PULL] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

On Saturday 15 September 2012 15:06:13 Lars-Peter Clausen wrote:
> On 09/15/2012 01:28 AM, Dave Airlie wrote:
> > On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart wrote:
> >> Hi Dave,
> >> 
> >> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> >> requires GEM and KMS/FB helpers that have been reviewed on the list and
> >> tested. Sascha is waiting for them to reach your tree to send a pull
> >> request for another new driver.
> > 
> > Just a quick review before I pull,
> > 
> > Why does include/drm/shmob_drm.h exist? this file is meant to define
> > the userspace API to the driver, if you don't have any userspace API
> > or driver specific ioctls, this file shouldn't be required. You might
> > want to create include/drm/shmob_internal.h maybe, if this is used as
> > an interface to other places in the kernel. I probably need to check
> > other have been doing the right thing here as well. (driver_drm.h
> > should be user facing only)
> > 
> > Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
> > no driver is ever going to want to tweak the drm_fbdev_cma_ops?
> 
> Obviously we can't, for the same reasons we can't know whether there will
> ever be a driver which needs to use custom fb_ops. It works fine as it is
> now for three different drivers. And other drivers making use of the cma
> buffer helpers are likely to have similar requirements, but if we ever get
> to a point where a driver needs custom fb_ops it is fairly easy to change
> it then.

Dave, are you fine with that ? If so I'll submit a new pull request with 
include/drm/shmob_drm.h moved to include/linux/platform_data/shmob_drm.h.

-- 
Regards,

Laurent Pinchart

Re: [PULL] SH Mobile DRM driver for v3.7

[Dave Airlie]

On Mon, Sep 17, 2012 at 1:38 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Saturday 15 September 2012 15:06:13 Lars-Peter Clausen wrote:
>> On 09/15/2012 01:28 AM, Dave Airlie wrote:
>> > On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart wrote:
>> >> Hi Dave,
>> >>
>> >> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
>> >> requires GEM and KMS/FB helpers that have been reviewed on the list and
>> >> tested. Sascha is waiting for them to reach your tree to send a pull
>> >> request for another new driver.
>> >
>> > Just a quick review before I pull,
>> >
>> > Why does include/drm/shmob_drm.h exist? this file is meant to define
>> > the userspace API to the driver, if you don't have any userspace API
>> > or driver specific ioctls, this file shouldn't be required. You might
>> > want to create include/drm/shmob_internal.h maybe, if this is used as
>> > an interface to other places in the kernel. I probably need to check
>> > other have been doing the right thing here as well. (driver_drm.h
>> > should be user facing only)
>> >
>> > Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
>> > no driver is ever going to want to tweak the drm_fbdev_cma_ops?
>>
>> Obviously we can't, for the same reasons we can't know whether there will
>> ever be a driver which needs to use custom fb_ops. It works fine as it is
>> now for three different drivers. And other drivers making use of the cma
>> buffer helpers are likely to have similar requirements, but if we ever get
>> to a point where a driver needs custom fb_ops it is fairly easy to change
>> it then.
>
> Dave, are you fine with that ? If so I'll submit a new pull request with
> include/drm/shmob_drm.h moved to include/linux/platform_data/shmob_drm.h.
>

Yeah it'll do for now, we'll have to see how many new drivers show up
using these helpers.

Dave.

[PULL v2] SH Mobile DRM driver for v3.7

[Laurent Pinchart]

Hi Dave,

Here's the second pull request for the SH Mobile DRM driver. Compared to v1, 
the include/drm/shmob_drm.h private header has been moved to 
include/linux/platform_data/.

The following changes since commit 0b2443ed4e07d7973e4554a2cc166bc35447b59e:

  drm/edid: limit printk when facing bad edid (2012-09-17 11:16:40 +1000)

are available in the git repository at:
  git://linuxtv.org/pinchartl/fbdev.git drm-lcdc

Lars-Peter Clausen (1):
      DRM: Add DRM KMS/FB CMA helper

Laurent Pinchart (2):
      drm: Add NV24 and NV42 pixel formats
      drm: Renesas SH Mobile DRM driver

Sascha Hauer (1):
      DRM: Add DRM GEM CMA helper

 drivers/gpu/drm/Kconfig                        |   17 +
 drivers/gpu/drm/Makefile                       |    3 +
 drivers/gpu/drm/drm_crtc.c                     |    6 +
 drivers/gpu/drm/drm_fb_cma_helper.c            |  406 +++++++++++++
 drivers/gpu/drm/drm_gem_cma_helper.c           |  251 ++++++++
 drivers/gpu/drm/shmobile/Kconfig               |   10 +
 drivers/gpu/drm/shmobile/Makefile              |    7 +
 drivers/gpu/drm/shmobile/shmob_drm_backlight.c |   90 +++
 drivers/gpu/drm/shmobile/shmob_drm_backlight.h |   23 +
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c      |  763 +++++++++++++++++++++++
 drivers/gpu/drm/shmobile/shmob_drm_crtc.h      |   60 ++
 drivers/gpu/drm/shmobile/shmob_drm_drv.c       |  361 +++++++++++
 drivers/gpu/drm/shmobile/shmob_drm_drv.h       |   47 ++
 drivers/gpu/drm/shmobile/shmob_drm_kms.c       |  160 +++++
 drivers/gpu/drm/shmobile/shmob_drm_kms.h       |   34 +
 drivers/gpu/drm/shmobile/shmob_drm_plane.c     |  268 +++++++++
 drivers/gpu/drm/shmobile/shmob_drm_plane.h     |   22 +
 drivers/gpu/drm/shmobile/shmob_drm_regs.h      |  311 ++++++++++
 include/drm/drm_fb_cma_helper.h                |   27 +
 include/drm/drm_fourcc.h                       |    2 +
 include/drm/drm_gem_cma_helper.h               |   44 ++
 include/linux/platform_data/shmob_drm.h        |   99 +++
 22 files changed, 3011 insertions(+), 0 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fb_cma_helper.c
 create mode 100644 drivers/gpu/drm/drm_gem_cma_helper.c
 create mode 100644 drivers/gpu/drm/shmobile/Kconfig
 create mode 100644 drivers/gpu/drm/shmobile/Makefile
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h
 create mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h
 create mode 100644 include/drm/drm_fb_cma_helper.h
 create mode 100644 include/drm/drm_gem_cma_helper.h
 create mode 100644 include/linux/platform_data/shmob_drm.h

-- 
Regards,

Laurent Pinchart