All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: "Chauhan, Vijay" <Vijay.Chauhan@netapp.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH]multipath-tools: Adding major:minor to multipathd logging for device discovery and removal
Date: Wed, 27 Feb 2013 21:54:01 +0100	[thread overview]
Message-ID: <1361998441.3199.0.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <F200AD42A082BC4088B232D13A916A89271FC620@SACEXCMBX02-PRD.hq.netapp.com>

On mer., 2013-02-27 at 14:05 +0000, Chauhan, Vijay wrote:
> Path name, HCTL and major:minor (for ex: srp and mptsas) could change during subsequent
> rediscovery of path and it becomes difficult to associate the paths with dm device using
> default verbosity in the syslog (when there are large number of dm device configured).
> multipathd logs few messages with path name and others with major:minor. We need to have
> association between  major:minor and device name with default verbosity.
> 
Right, applied.

Best regards,
Christophe Varoqui
www.opensvc.com

> Signed-off-by: Vijay Chauhan <vijay.chauhan@netapp.com>
> ---
> multipathd/main.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> This patch adds major:minor to log for path addition and path removal.
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 7f83a7a..95264fc 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -531,7 +531,8 @@ rescan:
>  			goto fail_map;
>  
>  	if (retries >= 0) {
> -		condlog(2, "%s path added to devmap %s", pp->dev, mpp->alias);
> +		condlog(2, "%s [%s]: path added to devmap %s",
> +			pp->dev, pp->dev_t, mpp->alias);
>  		return 0;
>  	}
>  	else
> @@ -636,8 +637,8 @@ ev_remove_path (struct path *pp, struct vectors * vecs)
>  			}
>  			sync_map_state(mpp);
>  
> -			condlog(2, "%s: path removed from map %s",
> -				pp->dev, mpp->alias);
> +			condlog(2, "%s [%s]: path removed from map %s",
> +				pp->dev, pp->dev_t, mpp->alias);
>  		}
>  	}
> 
> --

      reply	other threads:[~2013-02-27 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 14:05 [PATCH]multipath-tools: Adding major:minor to multipathd logging for device discovery and removal Chauhan, Vijay
2013-02-27 20:54 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361998441.3199.0.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=Vijay.Chauhan@netapp.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.