[PATCH]multipath-tools: Adding major:minor to multipathd logging for device discovery and removal

[PATCH]multipath-tools: Adding major:minor to multipathd logging for device discovery and removal

[Chauhan, Vijay]

Path name, HCTL and major:minor (for ex: srp and mptsas) could change during subsequent
rediscovery of path and it becomes difficult to associate the paths with dm device using
default verbosity in the syslog (when there are large number of dm device configured).
multipathd logs few messages with path name and others with major:minor. We need to have
association between  major:minor and device name with default verbosity.

Signed-off-by: Vijay Chauhan <vijay.chauhan@netapp.com>
---
multipathd/main.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

This patch adds major:minor to log for path addition and path removal.

diff --git a/multipathd/main.c b/multipathd/main.c
index 7f83a7a..95264fc 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -531,7 +531,8 @@ rescan:
 			goto fail_map;
 
 	if (retries >= 0) {
-		condlog(2, "%s path added to devmap %s", pp->dev, mpp->alias);
+		condlog(2, "%s [%s]: path added to devmap %s",
+			pp->dev, pp->dev_t, mpp->alias);
 		return 0;
 	}
 	else
@@ -636,8 +637,8 @@ ev_remove_path (struct path *pp, struct vectors * vecs)
 			}
 			sync_map_state(mpp);
 
-			condlog(2, "%s: path removed from map %s",
-				pp->dev, mpp->alias);
+			condlog(2, "%s [%s]: path removed from map %s",
+				pp->dev, pp->dev_t, mpp->alias);
 		}
 	}

--

Re: [PATCH]multipath-tools: Adding major:minor to multipathd logging for device discovery and removal

[Christophe Varoqui]

On mer., 2013-02-27 at 14:05 +0000, Chauhan, Vijay wrote:
> Path name, HCTL and major:minor (for ex: srp and mptsas) could change during subsequent
> rediscovery of path and it becomes difficult to associate the paths with dm device using
> default verbosity in the syslog (when there are large number of dm device configured).
> multipathd logs few messages with path name and others with major:minor. We need to have
> association between  major:minor and device name with default verbosity.
> 
Right, applied.

Best regards,
Christophe Varoqui
www.opensvc.com

> Signed-off-by: Vijay Chauhan <vijay.chauhan@netapp.com>
> ---
> multipathd/main.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> This patch adds major:minor to log for path addition and path removal.
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 7f83a7a..95264fc 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -531,7 +531,8 @@ rescan:
>  			goto fail_map;
>  
>  	if (retries >= 0) {
> -		condlog(2, "%s path added to devmap %s", pp->dev, mpp->alias);
> +		condlog(2, "%s [%s]: path added to devmap %s",
> +			pp->dev, pp->dev_t, mpp->alias);
>  		return 0;
>  	}
>  	else
> @@ -636,8 +637,8 @@ ev_remove_path (struct path *pp, struct vectors * vecs)
>  			}
>  			sync_map_state(mpp);
>  
> -			condlog(2, "%s: path removed from map %s",
> -				pp->dev, mpp->alias);
> +			condlog(2, "%s [%s]: path removed from map %s",
> +				pp->dev, pp->dev_t, mpp->alias);
>  		}
>  	}
> 
> --