From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
ricard.wanderlof@axis.com, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: torturetest: add the support for random data pattern
Date: Sat, 02 Mar 2013 16:44:53 +0200 [thread overview]
Message-ID: <1362235493.2745.11.camel@sauron> (raw)
In-Reply-To: <CAMiH66FFzeSg7r_hedet5deynxY6OF18UMcASsX-GaHjGmXiZQ@mail.gmail.com>
On Sat, 2013-02-16 at 12:00 +0800, Huang Shijie wrote:
> On Wed, Feb 13, 2013 at 6:37 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Tue, 2013-02-05 at 16:21 +0800, Huang Shijie wrote:
> >> Add a new module parameter 'pattern'. The meaning of the pattern is:
> >> (1) pattern == 0 for 55/AA pattern.
> >> (2) pattern < 0 for random pattern.
> >> (3) pattern > 0 for random pattern too, the value of the pattern is used
> >> as the seed for the random generator.
> >
> > Please, do not add parameters, make it simple - teach the test to use
> > both the old patterns plus additional cycles with random patterns.
>
> but if we do not add new parameter, how can we create a random seed?
Unless you have a real practical reason to let users pass the initial
random seed, do not do this.
> Is it ok without set the random seed?
I think so.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-02 14:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 2:20 [PATCH 1/2] mtd: torturetest: rewrite the erase-write-verify process into one block unit Huang Shijie
2013-02-05 2:20 ` Huang Shijie
2013-02-05 2:20 ` [PATCH 2/2] mtd: torturetest: add the support for random data pattern Huang Shijie
2013-02-05 2:20 ` Huang Shijie
2013-02-05 8:05 ` Ricard Wanderlof
2013-02-05 8:05 ` Ricard Wanderlof
2013-02-05 8:21 ` [PATCH v2] " Huang Shijie
2013-02-05 9:48 ` Ricard Wanderlof
2013-02-05 10:01 ` Huang Shijie
2013-02-13 10:37 ` Artem Bityutskiy
2013-02-16 4:00 ` Huang Shijie
2013-03-02 14:44 ` Artem Bityutskiy [this message]
2013-03-04 2:29 ` Huang Shijie
2013-02-05 8:21 ` [PATCH 2/2] " Huang Shijie
2013-02-05 8:21 ` Huang Shijie
2013-02-05 8:30 ` [PATCH V3] " Huang Shijie
2013-02-05 9:06 ` [PATCH v4] " Huang Shijie
2013-02-13 11:26 ` Ezequiel Garcia
2013-02-16 4:01 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362235493.2745.11.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.