All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH 2/2] mtd: torturetest: add the support for random data pattern
Date: Tue, 5 Feb 2013 16:21:31 +0800	[thread overview]
Message-ID: <5110C10B.5090502@freescale.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1302050900010.3736@lnxricardw.se.axis.com>

于 2013年02月05日 16:05, Ricard Wanderlof 写道:
>
> On Tue, 5 Feb 2013, Huang Shijie wrote:
>
>> Add a new module parameter 'pattern'. If it is set to zero, we will 
>> use the 55/AA pattern to torture the nand blocks; if it is set to a 
>> non-zero value, we will use the random data pattern.
>
> Not a big issue in any way, but if you're using a numeric parameter 
> value anyway, could not one use a range of the permissable values to 
> set a seed for the random generation, so that the test can be repeated 
> with the same set of random numbers?
It's ok to provide a seed to the mtd_torturetest.


>
> Something like
>
> 0 => 55/AA
> -1 => random
> 1 and up => random, specifying seed for random number generator.
>
I will add it in next version.

thanks for your review.

Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH 2/2] mtd: torturetest: add the support for random data pattern
Date: Tue, 5 Feb 2013 16:21:31 +0800	[thread overview]
Message-ID: <5110C10B.5090502@freescale.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1302050900010.3736@lnxricardw.se.axis.com>

于 2013年02月05日 16:05, Ricard Wanderlof 写道:
>
> On Tue, 5 Feb 2013, Huang Shijie wrote:
>
>> Add a new module parameter 'pattern'. If it is set to zero, we will 
>> use the 55/AA pattern to torture the nand blocks; if it is set to a 
>> non-zero value, we will use the random data pattern.
>
> Not a big issue in any way, but if you're using a numeric parameter 
> value anyway, could not one use a range of the permissable values to 
> set a seed for the random generation, so that the test can be repeated 
> with the same set of random numbers?
It's ok to provide a seed to the mtd_torturetest.


>
> Something like
>
> 0 => 55/AA
> -1 => random
> 1 and up => random, specifying seed for random number generator.
>
I will add it in next version.

thanks for your review.

Huang Shijie




  parent reply	other threads:[~2013-02-05  8:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05  2:20 [PATCH 1/2] mtd: torturetest: rewrite the erase-write-verify process into one block unit Huang Shijie
2013-02-05  2:20 ` Huang Shijie
2013-02-05  2:20 ` [PATCH 2/2] mtd: torturetest: add the support for random data pattern Huang Shijie
2013-02-05  2:20   ` Huang Shijie
2013-02-05  8:05   ` Ricard Wanderlof
2013-02-05  8:05     ` Ricard Wanderlof
2013-02-05  8:21     ` [PATCH v2] " Huang Shijie
2013-02-05  9:48       ` Ricard Wanderlof
2013-02-05 10:01         ` Huang Shijie
2013-02-13 10:37       ` Artem Bityutskiy
2013-02-16  4:00         ` Huang Shijie
2013-03-02 14:44           ` Artem Bityutskiy
2013-03-04  2:29             ` Huang Shijie
2013-02-05  8:21     ` Huang Shijie [this message]
2013-02-05  8:21       ` [PATCH 2/2] " Huang Shijie
2013-02-05  8:30     ` [PATCH V3] " Huang Shijie
2013-02-05  9:06       ` [PATCH v4] " Huang Shijie
2013-02-13 11:26         ` Ezequiel Garcia
2013-02-16  4:01           ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5110C10B.5090502@freescale.com \
    --to=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=ricard.wanderlof@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.