* [PATCH] buildhistory: Allow the version backwards check to be disabled
@ 2013-03-03 13:07 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2013-03-03 13:07 UTC (permalink / raw)
To: openembedded-core; +Cc: Eggleton, Paul
When the PR service is not enabled, the versions can go backwards and there
are cases we don't want to know about this. This patch adds a variable
allowing these checks to be turned off whilst still using buildhistory.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index a20d03d..43780ad 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -14,6 +14,7 @@ BUILDHISTORY_DIR_PACKAGE = "${BUILDHISTORY_DIR}/packages/${MULTIMACH_TARGET_SYS}
BUILDHISTORY_COMMIT ?= "0"
BUILDHISTORY_COMMIT_AUTHOR ?= "buildhistory <buildhistory@${DISTRO}>"
BUILDHISTORY_PUSH_REPO ?= ""
+BUILDHISTORY_CHECKVERBACKWARDS ?= "1"
# Must inherit package first before changing PACKAGEFUNCS
inherit package
@@ -183,14 +184,15 @@ python buildhistory_emit_pkghistory() {
# Find out what the last version was
# Make sure the version did not decrease
#
- lastversion = getlastpkgversion(pkg)
- if lastversion:
- last_pkge = lastversion.pkge
- last_pkgv = lastversion.pkgv
- last_pkgr = lastversion.pkgr
- r = bb.utils.vercmp((pkge, pkgv, pkgr), (last_pkge, last_pkgv, last_pkgr))
- if r < 0:
- bb.error("Package version for package %s went backwards which would break package feeds from (%s:%s-%s to %s:%s-%s)" % (pkg, last_pkge, last_pkgv, last_pkgr, pkge, pkgv, pkgr))
+ if d.getVar("BUILDHISTORY_CHECKVERBACKWARDS", True) == "1":
+ lastversion = getlastpkgversion(pkg)
+ if lastversion:
+ last_pkge = lastversion.pkge
+ last_pkgv = lastversion.pkgv
+ last_pkgr = lastversion.pkgr
+ r = bb.utils.vercmp((pkge, pkgv, pkgr), (last_pkge, last_pkgv, last_pkgr))
+ if r < 0:
+ bb.error("Package version for package %s went backwards which would break package feeds from (%s:%s-%s to %s:%s-%s)" % (pkg, last_pkge, last_pkgv, last_pkgr, pkge, pkgv, pkgr))
pkginfo = PackageInfo(pkg)
# Apparently the version can be different on a per-package basis (see Python)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-03 13:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-03 13:07 [PATCH] buildhistory: Allow the version backwards check to be disabled Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.