From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
Huang Shijie <shijie8@gmail.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}
Date: Mon, 04 Mar 2013 09:50:34 +0200 [thread overview]
Message-ID: <1362383434.2943.5.camel@sauron> (raw)
In-Reply-To: <513437DF.2030505@freescale.com>
On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote:
> The current code uses the @id to store the device id(byte 1).
> But if we use the 8 bytes id data as the keyword, and expand the @id
> field to 8byte array,
> the device id is the second byte now. All the added zeros are for the
I do not think you need to store the full array of ID's. Device ID's for
all the 4 of above chips are different, which is enough to distinguish
between them.
The only thing you need to add is the OOB size field to 'struct
nand_flash_dev'.
--
Best Regards,
Artem Bityutskiy
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: Huang Shijie <shijie8@gmail.com>,
dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}
Date: Mon, 04 Mar 2013 09:50:34 +0200 [thread overview]
Message-ID: <1362383434.2943.5.camel@sauron> (raw)
In-Reply-To: <513437DF.2030505@freescale.com>
On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote:
> The current code uses the @id to store the device id(byte 1).
> But if we use the 8 bytes id data as the keyword, and expand the @id
> field to 8byte array,
> the device id is the second byte now. All the added zeros are for the
I do not think you need to store the full array of ID's. Device ID's for
all the 4 of above chips are different, which is enough to distinguish
between them.
The only thing you need to add is the OOB size field to 'struct
nand_flash_dev'.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-04 7:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 4:57 [PATCH V3 0/3] mtd: use the full-id as the keyword Huang Shijie
2013-01-28 4:57 ` Huang Shijie
2013-01-28 4:57 ` [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{} Huang Shijie
2013-01-28 4:57 ` Huang Shijie
2013-02-12 15:47 ` Artem Bityutskiy
2013-02-12 15:47 ` Artem Bityutskiy
2013-02-16 3:56 ` Huang Shijie
2013-02-16 3:56 ` Huang Shijie
2013-03-02 14:21 ` Artem Bityutskiy
2013-03-02 14:21 ` Artem Bityutskiy
2013-03-04 5:57 ` Huang Shijie
2013-03-04 5:57 ` Huang Shijie
2013-03-04 7:50 ` Artem Bityutskiy [this message]
2013-03-04 7:50 ` Artem Bityutskiy
2013-03-04 8:08 ` Huang Shijie
2013-03-04 8:08 ` Huang Shijie
2013-03-04 8:24 ` Artem Bityutskiy
2013-03-04 8:24 ` Artem Bityutskiy
2013-03-04 8:40 ` Huang Shijie
2013-03-04 8:40 ` Huang Shijie
2013-03-04 8:46 ` Artem Bityutskiy
2013-03-04 8:46 ` Artem Bityutskiy
2013-03-04 8:59 ` Huang Shijie
2013-03-04 8:59 ` Huang Shijie
2013-03-04 19:27 ` Brian Norris
2013-03-04 19:27 ` Brian Norris
2013-08-08 18:38 ` Brian Norris
2013-08-08 18:38 ` Brian Norris
2013-03-04 8:37 ` Artem Bityutskiy
2013-03-04 8:37 ` Artem Bityutskiy
2013-03-04 8:57 ` Huang Shijie
2013-03-04 8:57 ` Huang Shijie
2013-02-28 8:25 ` Huang Shijie
2013-02-28 8:25 ` Huang Shijie
2013-03-02 14:19 ` Artem Bityutskiy
2013-03-02 14:19 ` Artem Bityutskiy
2013-03-04 3:06 ` Huang Shijie
2013-03-04 3:06 ` Huang Shijie
2013-01-28 4:57 ` [PATCH V3 2/3] mtd: add a new table for the unparsable nand chips Huang Shijie
2013-01-28 4:57 ` Huang Shijie
2013-01-28 4:57 ` [PATCH V3 3/3] mtd: add the new detection method " Huang Shijie
2013-01-28 4:57 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362383434.2943.5.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.