All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCHv3 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Mon, 04 Mar 2013 16:49:13 +0100	[thread overview]
Message-ID: <1362412153.21028.35.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <512DBE77.9040902@cozybit.com> (sfid-20130227_090620_764902_9D1627C6)

On Wed, 2013-02-27 at 09:06 +0100, Marco Porsch wrote:

> >>   struct ieee802_11_elems;
> >>   struct ieee80211_mesh_sync_ops {
> >> -       void (*rx_bcn_presp)(struct ieee80211_sub_if_data *sdata,
> >> -                            u16 stype,
> >> -                            struct ieee80211_mgmt *mgmt,
> >> -                            struct ieee802_11_elems *elems,
> >> -                            struct ieee80211_rx_status *rx_status);
> >> +       void (*rx_bcn)(struct sta_info *sta,
> >> +                      struct ieee80211_mgmt *mgmt,
> >> +                      struct ieee802_11_elems *elems,
> >> +                      u64 t_r);
> >
> > Why not continue to sync against probe responses?
> > mesh_neighbour_update() gets these as well.
> 
> Because there was a comment about the standard mentioning only beacon 
> frames. Fooled me here =/
> Now I see that the standard explicitly mentions probe responses as well.
> Is the sync code currently ready to handle probe responses? I am not 
> perfectly sure about the sta->t_offset_setpoint stuff.

I'm going to drop these patches until you figure this out and tell me
otherwise.

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Marco Porsch <marco@cozybit.com>
Cc: Thomas Pedersen <thomas@cozybit.com>,
	mcgrof@qca.qualcomm.com, jouni@qca.qualcomm.com,
	vthiagar@qca.qualcomm.com, senthilb@qca.qualcomm.com,
	sleffler@google.com, linux-wireless@vger.kernel.org,
	devel@lists.open80211s.org, ath9k-devel@lists.ath9k.org
Subject: Re: [PATCHv3 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Mon, 04 Mar 2013 16:49:13 +0100	[thread overview]
Message-ID: <1362412153.21028.35.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <512DBE77.9040902@cozybit.com> (sfid-20130227_090620_764902_9D1627C6)

On Wed, 2013-02-27 at 09:06 +0100, Marco Porsch wrote:

> >>   struct ieee802_11_elems;
> >>   struct ieee80211_mesh_sync_ops {
> >> -       void (*rx_bcn_presp)(struct ieee80211_sub_if_data *sdata,
> >> -                            u16 stype,
> >> -                            struct ieee80211_mgmt *mgmt,
> >> -                            struct ieee802_11_elems *elems,
> >> -                            struct ieee80211_rx_status *rx_status);
> >> +       void (*rx_bcn)(struct sta_info *sta,
> >> +                      struct ieee80211_mgmt *mgmt,
> >> +                      struct ieee802_11_elems *elems,
> >> +                      u64 t_r);
> >
> > Why not continue to sync against probe responses?
> > mesh_neighbour_update() gets these as well.
> 
> Because there was a comment about the standard mentioning only beacon 
> frames. Fooled me here =/
> Now I see that the standard explicitly mentions probe responses as well.
> Is the sync code currently ready to handle probe responses? I am not 
> perfectly sure about the sta->t_offset_setpoint stuff.

I'm going to drop these patches until you figure this out and tell me
otherwise.

johannes


  reply	other threads:[~2013-03-04 15:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 16:00 [ath9k-devel] [PATCHv3 1/3] mac80211: move mesh sync beacon handler into neighbour_update Marco Porsch
2013-02-25 16:00 ` Marco Porsch
2013-02-25 16:00 ` [ath9k-devel] [PATCHv3 2/3] mac80211: mesh power save doze scheduling Marco Porsch
2013-02-25 16:00   ` Marco Porsch
2013-02-25 16:00 ` [ath9k-devel] [PATCHv3 3/3] ath9k: mesh powersave support Marco Porsch
2013-02-25 16:00   ` Marco Porsch
2013-02-26 21:31 ` [ath9k-devel] [PATCHv3 1/3] mac80211: move mesh sync beacon handler into neighbour_update Thomas Pedersen
2013-02-26 21:31   ` Thomas Pedersen
2013-02-27  8:06   ` [ath9k-devel] " Marco Porsch
2013-02-27  8:06     ` Marco Porsch
2013-03-04 15:49     ` Johannes Berg [this message]
2013-03-04 15:49       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362412153.21028.35.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.