[PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Takashi Iwai]

The DriveGuard chips on the new HP laptops are with a new PnP ID
"HPQ6007".  It should be compatible with older chips.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

---
 drivers/platform/x86/hp_accel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
index e64a7a8..b6c4305 100644
--- a/drivers/platform/x86/hp_accel.c
+++ b/drivers/platform/x86/hp_accel.c
@@ -77,6 +77,7 @@ static inline void delayed_sysfs_set(struct led_classdev *led_cdev,
 static struct acpi_device_id lis3lv02d_device_ids[] = {
 	{"HPQ0004", 0}, /* HP Mobile Data Protection System PNP */
 	{"HPQ6000", 0}, /* HP Mobile Data Protection System PNP */
+	{"HPQ6007", 0}, /* HP Mobile Data Protection System PNP */
 	{"", 0},
 };
 MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
-- 
1.8.1.4

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Takashi Iwai]

At Tue, 26 Feb 2013 18:19:03 +0100,
Takashi Iwai wrote:
> 
> The DriveGuard chips on the new HP laptops are with a new PnP ID
> "HPQ6007".  It should be compatible with older chips.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Ping...  Eric, Matthew, or can anyone check this?


thanks,

Takashi

> 
> ---
>  drivers/platform/x86/hp_accel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
> index e64a7a8..b6c4305 100644
> --- a/drivers/platform/x86/hp_accel.c
> +++ b/drivers/platform/x86/hp_accel.c
> @@ -77,6 +77,7 @@ static inline void delayed_sysfs_set(struct led_classdev *led_cdev,
>  static struct acpi_device_id lis3lv02d_device_ids[] = {
>  	{"HPQ0004", 0}, /* HP Mobile Data Protection System PNP */
>  	{"HPQ6000", 0}, /* HP Mobile Data Protection System PNP */
> +	{"HPQ6007", 0}, /* HP Mobile Data Protection System PNP */
>  	{"", 0},
>  };
>  MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
> -- 
> 1.8.1.4
> 

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Éric Piel]

On 26/02/13 18:19, Takashi Iwai wrote:
> The DriveGuard chips on the new HP laptops are with a new PnP ID
> "HPQ6007".  It should be compatible with older chips.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Hi,
Sorry for the delay. The driver is able to detect the actual type of 
accelerometer behind, so indeed it should work fine.

Thanks for the patch, here is my:
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>

Matthew, could you pick this patch into your tree?
Cheers,
Éric
>
> ---
>   drivers/platform/x86/hp_accel.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
> index e64a7a8..b6c4305 100644
> --- a/drivers/platform/x86/hp_accel.c
> +++ b/drivers/platform/x86/hp_accel.c
> @@ -77,6 +77,7 @@ static inline void delayed_sysfs_set(struct led_classdev *led_cdev,
>   static struct acpi_device_id lis3lv02d_device_ids[] = {
>   	{"HPQ0004", 0}, /* HP Mobile Data Protection System PNP */
>   	{"HPQ6000", 0}, /* HP Mobile Data Protection System PNP */
> +	{"HPQ6007", 0}, /* HP Mobile Data Protection System PNP */
>   	{"", 0},
>   };
>   MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
>

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Matthew Garrett]

On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
> On 26/02/13 18:19, Takashi Iwai wrote:
> > The DriveGuard chips on the new HP laptops are with a new PnP ID
> > "HPQ6007".  It should be compatible with older chips.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Hi,
> Sorry for the delay. The driver is able to detect the actual type of 
> accelerometer behind, so indeed it should work fine.
> 
> Thanks for the patch, here is my:
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> 
> Matthew, could you pick this patch into your tree?

Will do.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Matthew Garrett]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 766 bytes --]

On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
> On 26/02/13 18:19, Takashi Iwai wrote:
> > The DriveGuard chips on the new HP laptops are with a new PnP ID
> > "HPQ6007".  It should be compatible with older chips.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Hi,
> Sorry for the delay. The driver is able to detect the actual type of 
> accelerometer behind, so indeed it should work fine.
> 
> Thanks for the patch, here is my:
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> 
> Matthew, could you pick this patch into your tree?

Will do.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Takashi Iwai]

At Tue, 5 Mar 2013 15:42:58 +0000,
Matthew Garrett wrote:
> 
> On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
> > On 26/02/13 18:19, Takashi Iwai wrote:
> > > The DriveGuard chips on the new HP laptops are with a new PnP ID
> > > "HPQ6007".  It should be compatible with older chips.
> > >
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > Hi,
> > Sorry for the delay. The driver is able to detect the actual type of 
> > accelerometer behind, so indeed it should work fine.
> > 
> > Thanks for the patch, here is my:
> > Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> > 
> > Matthew, could you pick this patch into your tree?
> 
> Will do.

Thanks!


Takashi

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Shuah Khan]

On Tue, Mar 5, 2013 at 8:45 AM, Takashi Iwai <tiwai@suse.de> wrote:
> At Tue, 5 Mar 2013 15:42:58 +0000,
> Matthew Garrett wrote:
>>
>> On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
>> > On 26/02/13 18:19, Takashi Iwai wrote:
>> > > The DriveGuard chips on the new HP laptops are with a new PnP ID
>> > > "HPQ6007".  It should be compatible with older chips.
>> > >
>> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> > Hi,
>> > Sorry for the delay. The driver is able to detect the actual type of
>> > accelerometer behind, so indeed it should work fine.
>> >
>> > Thanks for the patch, here is my:
>> > Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
>> >
>> > Matthew, could you pick this patch into your tree?
>>
>> Will do.
>
> Thanks!
>
>
> Takashi

Takashi,

Should this be tagged for stables releases? This patch went into suse
git and just checking to see if it should go into stable releases.

Thanks,
-- Shuah

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Shuah Khan]

On Tue, Mar 5, 2013 at 8:45 AM, Takashi Iwai <tiwai@suse.de> wrote:
> At Tue, 5 Mar 2013 15:42:58 +0000,
> Matthew Garrett wrote:
>>
>> On Tue, 2013-03-05 at 12:49 +0100, �ric Piel wrote:
>> > On 26/02/13 18:19, Takashi Iwai wrote:
>> > > The DriveGuard chips on the new HP laptops are with a new PnP ID
>> > > "HPQ6007".  It should be compatible with older chips.
>> > >
>> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> > Hi,
>> > Sorry for the delay. The driver is able to detect the actual type of
>> > accelerometer behind, so indeed it should work fine.
>> >
>> > Thanks for the patch, here is my:
>> > Acked-by: �ric Piel <eric.piel@tremplin-utc.net>
>> >
>> > Matthew, could you pick this patch into your tree?
>>
>> Will do.
>
> Thanks!
>
>
> Takashi

Takashi,

Should this be tagged for stables releases? This patch went into suse
git and just checking to see if it should go into stable releases.

Thanks,
-- Shuah

Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

[Éric Piel]

On 08-03-13 23:59, Shuah Khan wrote:
:
> Should this be tagged for stables releases? This patch went into suse
> git and just checking to see if it should go into stable releases.
Hello,
This patch will make the module automatically load on some new HP 
laptops. So although it's not fixing a bug, it will extend hardware 
support (a very little bit), which can be considered material for stable 
trees, indeed.

Cheers,
Éric