Re: [PATCH 10 of 11 v4] xl: add node-affinity to the output of `xl list`

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1249 bytes --]

On lun, 2013-03-18 at 14:13 +0000, Ian Campbell wrote:
> On Fri, 2013-03-15 at 02:30 +0000, Dario Faggioli wrote:
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
Thanks!

> [...]
> >              if (rc < 0)
> > -                printf("  -");
> > +                printf("                -");
> >              else {
> > -                printf("  %s", buf);
> > +                printf(" %16s", buf);
> >                  free(buf);
> 
> If you do end up respinning for any reason then this could be made less
> manual/error prone by using "%16s" even in the "-" case. Might even be
> possible to combine the whole lot, since free(NULL) is safe:
> 	printf(" %16s", rc < 0 : "" ? buf);
> 	free(buf);
> (assuming buf == NULL whenever rc < 0, I didn't check)
> 
I am respinning, and I'll take a look at this.

Thanks again,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel