All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Sam Leffler <sleffler@chromium.org>
Subject: Re: Radiotap injected rates
Date: Mon, 18 Mar 2013 20:26:08 +0100	[thread overview]
Message-ID: <1363634768.8260.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130317215544.GA7031@gobelin> (sfid-20130317_225612_791728_FF17B65A)

On Sun, 2013-03-17 at 22:55 +0100, Karl Beldan wrote:
> Hi,
> 
> Some time ago the rate selection for radiotap injected frames did not
> make it essentially for mac80211 getting short in IEEE80211_TX_CTL_*s.
> 
> Would it be acceptable to replace the originally proposed:
> 
> 
> -	if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL))
> +	if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL) &&
> +	    !(info->flags & IEEE80211_TX_CTL_NO_RC))
>  		CALL_TXH(ieee80211_tx_h_rate_ctrl);
> 
> with something like :
> 
> -	if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL))
> +	if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL) &&
> +	    !(info->flags & IEEE80211_TX_CTL_INJECTED && info->control.rates[i]))
> 		CALL_TXH(ieee80211_tx_h_rate_ctrl);

No, older wpa_supplicant/hostapd still use monitor interfaces for
management frame transmissions, and require rate control.

johannes


  reply	other threads:[~2013-03-18 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-17 21:55 Radiotap injected rates Karl Beldan
2013-03-18 19:26 ` Johannes Berg [this message]
2013-03-18 19:54   ` Karl Beldan
2013-03-22 12:24     ` Johannes Berg
2013-03-22 13:27       ` Karl Beldan
2013-03-22 13:32         ` Johannes Berg
2013-03-22 13:53           ` Karl Beldan
2013-03-22 14:00             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363634768.8260.16.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=karl.beldan@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sleffler@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.