From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Sam Leffler <sleffler@chromium.org>
Subject: Re: Radiotap injected rates
Date: Fri, 22 Mar 2013 13:24:54 +0100 [thread overview]
Message-ID: <1363955094.8238.32.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130318195406.GB17878@gobelin> (sfid-20130318_205432_783925_0898DAE7)
On Mon, 2013-03-18 at 20:54 +0100, Karl Beldan wrote:
> > No, older wpa_supplicant/hostapd still use monitor interfaces for
> > management frame transmissions, and require rate control.
> >
>
> Since they require rate control, I guess they don't pass any radiotap
> IEEE80211_RADIOTAP_{RATE,MCS} ? In that case that wouldn't disturb them.
Yeah, indeed, I wasn't looking right ...
> And, oops typo, I meant :
>
> + !(info->flags & IEEE80211_TX_CTL_INJECTED && info->control.rates[0] != -1))
>
> with info->control.rates[0] properly set in the radiotap header parsing,
> instead of :
>
> > > + !(info->flags & IEEE80211_TX_CTL_INJECTED && info->control.rates[i]))
>
> If that changes anything to what you guessed.
Well actually this won't work anyway because control.rates[] isn't
initialized to -1.
johannes
next prev parent reply other threads:[~2013-03-22 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 21:55 Radiotap injected rates Karl Beldan
2013-03-18 19:26 ` Johannes Berg
2013-03-18 19:54 ` Karl Beldan
2013-03-22 12:24 ` Johannes Berg [this message]
2013-03-22 13:27 ` Karl Beldan
2013-03-22 13:32 ` Johannes Berg
2013-03-22 13:53 ` Karl Beldan
2013-03-22 14:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363955094.8238.32.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.