From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 0/5] cpuacct, cgroup: Kill cgroup_subsys.active
Date: Fri, 29 Mar 2013 11:36:00 +0100 [thread overview]
Message-ID: <1364553360.5053.84.camel@laptop> (raw)
In-Reply-To: <51553813.10004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, 2013-03-29 at 14:43 +0800, Li Zefan wrote:
> cpuacct is the only user of cgroup_subsys.active flag.
>
> The flag is needed because cpuacct_charge() and
> cpuacct_account_field() can
> be called when cpuacct hasn't been initialized during system bootup.
>
> This patch initializes cpuacct earlier, and the result is we don't
> have
> to check the flag in scheduler hot path.
>
> Note, this patchset is based on "[PATCH v2 0/7] sched: Split cpuacct"
>
> http://lkml.org/lkml/2013/3/28/1
>
> 0001-cpuacct-allocate-per_cpu-cpuusage-for-root-cpuacct-s.patch
> 0002-cpuacct-Initialize-root-cpuacct-earlier.patch
> 0003-cpuacct-Initialize-cpuacct-subsystem-earlier.patch
> 0004-cpuacct-No-need-to-check-subsys-active-state.patch
> 0005-cgroup-Remove-subsys.active-flag.patch
Seems sane enough
Acked-by: Peter Zijlstra <a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Li Zefan <lizefan@huawei.com>
Cc: Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] cpuacct, cgroup: Kill cgroup_subsys.active
Date: Fri, 29 Mar 2013 11:36:00 +0100 [thread overview]
Message-ID: <1364553360.5053.84.camel@laptop> (raw)
In-Reply-To: <51553813.10004@huawei.com>
On Fri, 2013-03-29 at 14:43 +0800, Li Zefan wrote:
> cpuacct is the only user of cgroup_subsys.active flag.
>
> The flag is needed because cpuacct_charge() and
> cpuacct_account_field() can
> be called when cpuacct hasn't been initialized during system bootup.
>
> This patch initializes cpuacct earlier, and the result is we don't
> have
> to check the flag in scheduler hot path.
>
> Note, this patchset is based on "[PATCH v2 0/7] sched: Split cpuacct"
>
> http://lkml.org/lkml/2013/3/28/1
>
> 0001-cpuacct-allocate-per_cpu-cpuusage-for-root-cpuacct-s.patch
> 0002-cpuacct-Initialize-root-cpuacct-earlier.patch
> 0003-cpuacct-Initialize-cpuacct-subsystem-earlier.patch
> 0004-cpuacct-No-need-to-check-subsys-active-state.patch
> 0005-cgroup-Remove-subsys.active-flag.patch
Seems sane enough
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
next prev parent reply other threads:[~2013-03-29 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 6:43 [PATCH v2 0/5] cpuacct, cgroup: Kill cgroup_subsys.active Li Zefan
2013-03-29 6:43 ` Li Zefan
2013-03-29 6:43 ` [PATCH v2 1/5] cpuacct: allocate per_cpu cpuusage for root cpuacct statically Li Zefan
2013-04-10 13:44 ` [tip:sched/core] sched/cpuacct: Allocate " tip-bot for Li Zefan
[not found] ` <51553813.10004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-03-29 6:44 ` [PATCH v2 2/5] cpuacct: Initialize root cpuacct earlier Li Zefan
2013-03-29 6:44 ` Li Zefan
2013-04-10 13:46 ` [tip:sched/core] sched/cpuacct: " tip-bot for Li Zefan
2013-03-29 6:44 ` [PATCH v2 3/5] cpuacct: Initialize cpuacct subsystem earlier Li Zefan
2013-03-29 6:44 ` Li Zefan
2013-04-10 13:47 ` [tip:sched/core] sched/cpuacct: " tip-bot for Li Zefan
2013-03-29 10:36 ` Peter Zijlstra [this message]
2013-03-29 10:36 ` [PATCH v2 0/5] cpuacct, cgroup: Kill cgroup_subsys.active Peter Zijlstra
2013-04-09 1:29 ` Li Zefan
2013-04-09 1:29 ` Li Zefan
2013-03-29 6:44 ` [PATCH v2 4/5] cpuacct: No need to check subsys active state Li Zefan
2013-04-10 13:48 ` [tip:sched/core] sched/cpuacct: " tip-bot for Li Zefan
2013-03-29 6:44 ` [PATCH v2 5/5] cgroup: Kill subsys.active flag Li Zefan
2013-04-10 13:49 ` [tip:sched/core] " tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364553360.5053.84.camel@laptop \
--to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.