All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, mingo@redhat.com, x86@kernel.org
Cc: rth@twiddle.net, linux@arm.linux.org.uk, msalter@redhat.com,
	starvik@axis.com, dhowells@redhat.com, tony.luck@intel.com,
	benh@kernel.crashing.org, takata@linux-m32r.org,
	geert@linux-m68k.org, james.hogan@imgtec.com, monstr@monstr.eu,
	ralf@linux-mips.org, jonas@southpole.se, rkuo@codeaurora.org,
	schwidefsky@de.ibm.com, liqin.chen@sunplusct.com,
	davem@davemloft.net, lethal@linux-sh.org, vgupta@synopsys.com,
	chris@zankel.net, cmetcalf@tilera.com,
	ysato@users.sourceforge.jp, gxt@mprc.pku.edu.cn,
	jdike@addtoit.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 7/7] arc, print-fatal-signals: reduce duplicated information
Date: Wed,  3 Apr 2013 12:14:57 -0700	[thread overview]
Message-ID: <1365016497-32033-8-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1365016497-32033-1-git-send-email-tj@kernel.org>

From: Vineet Gupta <vgupta@synopsys.com>

After the recent generic debug info on dump_stack() and friends, arc
is printing duplicate information on debug dumps.

 [ARCLinux]$ ./crash
 crash/50: potentially unexpected fatal signal 11.	<-- [1]
 /sbin/crash, TGID 50					<-- [2]
 Pid: 50, comm: crash Not tainted 3.9.0-rc4+ #132 	<-- [3]
 ...

Remove them.

tj: Updated patch desc.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
 arch/arc/kernel/troubleshoot.c | 2 +-
 kernel/signal.c                | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/kernel/troubleshoot.c
index 158bbeb..39bbf58 100644
--- a/arch/arc/kernel/troubleshoot.c
+++ b/arch/arc/kernel/troubleshoot.c
@@ -75,7 +75,7 @@ void print_task_path_n_nm(struct task_struct *tsk, char *buf)
 	}
 
 done:
-	pr_info("%s, TGID %u\n", path_nm, tsk->tgid);
+	pr_info("Path: %s\n", path_nm);
 }
 EXPORT_SYMBOL(print_task_path_n_nm);
 
diff --git a/kernel/signal.c b/kernel/signal.c
index bb7ca79..92139dc 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1163,8 +1163,7 @@ static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
 static void print_fatal_signal(int signr)
 {
 	struct pt_regs *regs = signal_pt_regs();
-	printk(KERN_INFO "%s/%d: potentially unexpected fatal signal %d.\n",
-		current->comm, task_pid_nr(current), signr);
+	printk(KERN_INFO "potentially unexpected fatal signal %d.\n", signr);
 
 #if defined(__i386__) && !defined(__arch_um__)
 	printk(KERN_INFO "code at %08lx: ", regs->ip);
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-03 19:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 19:14 [PATCHSET v2] arch: unify task dump debug info Tejun Heo
2013-04-03 19:14 ` [PATCH 1/7] x86: don't show trace beyond show_stack(NULL, NULL) Tejun Heo
2013-04-08 16:08   ` Ingo Molnar
2013-04-08 17:57     ` Tejun Heo
2013-04-10 10:35       ` Ingo Molnar
2013-04-10 18:54         ` Tejun Heo
2013-04-10 20:10   ` [PATCH UPDATED 1/7] x86: don't show trace into stacktrace machinery Tejun Heo
2013-04-10 20:10     ` Tejun Heo
2013-04-10 20:22     ` Borislav Petkov
2013-04-10 21:09       ` Tejun Heo
2013-04-10 21:18   ` [PATCH UPDATED v2 " Tejun Heo
2013-04-10 21:18     ` Tejun Heo
2013-04-03 19:14 ` [PATCH 2/7] sparc32: make show_stack() acquire %fp if @_ksp is not specified Tejun Heo
2013-04-03 19:14 ` [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-04-04  7:13   ` Martin Schwidefsky
2013-04-12 20:39   ` Chris Metcalf
2013-04-12 20:39     ` Chris Metcalf
2013-04-12 21:59     ` Tejun Heo
2013-04-03 19:14 ` [PATCH 4/7] dmi: morph dmi_dump_ids() into dmi_format_ids() which formats into a buffer Tejun Heo
2013-04-03 19:14 ` [PATCH 5/7] dump_stack: implement arch-specific hardware description in task dumps Tejun Heo
2013-04-03 19:14 ` [PATCH 6/7] dump_stack: unify debug information printed by show_regs() Tejun Heo
2013-04-12 20:37   ` Chris Metcalf
2013-04-12 20:37     ` Chris Metcalf
2013-04-03 19:14 ` Tejun Heo [this message]
2013-04-08 15:31 ` [PATCHSET v2] arch: unify task dump debug info Tejun Heo
2013-04-11 18:47   ` Tejun Heo
2013-04-12  5:42     ` Ingo Molnar
2013-04-13  1:14     ` rkuo
2013-04-18 14:34 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365016497-32033-8-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=chris@zankel.net \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=james.hogan@imgtec.com \
    --cc=jdike@addtoit.com \
    --cc=jonas@southpole.se \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.chen@sunplusct.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=vgupta@synopsys.com \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.