From: Chris Metcalf <cmetcalf@tilera.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mingo@redhat.com, x86@kernel.org,
rth@twiddle.net, linux@arm.linux.org.uk, msalter@redhat.com,
starvik@axis.com, dhowells@redhat.com, tony.luck@intel.com,
benh@kernel.crashing.org, takata@linux-m32r.org,
geert@linux-m68k.org, james.hogan@imgtec.com, monstr@monstr.eu,
ralf@linux-mips.org, jonas@southpole.se, rkuo@codeaurora.org,
schwidefsky@de.ibm.com, liqin.chen@sunplusct.com,
davem@davemloft.net, lethal@linux-sh.org, vgupta@synopsys.com,
chris@zankel.net, ysato@users.sourceforge.jp,
gxt@mprc.pku.edu.cn, jdike@addtoit.com,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>,
uclinux-dist-devel@blackfin.uclinux.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors
Date: Fri, 12 Apr 2013 16:39:01 -0400 [thread overview]
Message-ID: <516870E5.3050901@tilera.com> (raw)
In-Reply-To: <1365016497-32033-4-git-send-email-tj@kernel.org>
On 4/3/2013 3:14 PM, Tejun Heo wrote:
> This patch expands the dummy fallback dump_stack() implementation in
> lib/dump_stack.c such that it prints out debug information (taken from
> x86) and invokes show_stack(NULL, NULL) and drops arch-specific
> dump_stack() implementations in all archs except blackfin. Blackfin's
> dump_stack() does something wonky that I don't understand.
arch/tile has a dump_stack() entry point in assembly (see arch/tile/kernel/entry.S) that passes to _dump_stack(), which passes to dump_stack_regs(), which passes to tile_show_stack(). Similarly, show_stack() passes to tile_show_stack(), which does lots of work to cross into userspace and continue showing the stack if possible, print symbol info for both kernel and userspace, etc. I don't know if that's all supported fully in Tejun's generic version.
Would it make sense for me to look at this after it's merged up into -next and see what tile needs? Unfortunately I'm taking off for a week's vacation so won't be able to do much until after the 23rd.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
WARNING: multiple messages have this Message-ID (diff)
From: Chris Metcalf <cmetcalf@tilera.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>, <mingo@redhat.com>, <x86@kernel.org>,
<rth@twiddle.net>, <linux@arm.linux.org.uk>, <msalter@redhat.com>,
<starvik@axis.com>, <dhowells@redhat.com>, <tony.luck@intel.com>,
<benh@kernel.crashing.org>, <takata@linux-m32r.org>,
<geert@linux-m68k.org>, <james.hogan@imgtec.com>,
<monstr@monstr.eu>, <ralf@linux-mips.org>, <jonas@southpole.se>,
<rkuo@codeaurora.org>, <schwidefsky@de.ibm.com>,
<liqin.chen@sunplusct.com>, <davem@davemloft.net>,
<lethal@linux-sh.org>, <vgupta@synopsys.com>, <chris@zankel.net>,
<ysato@users.sourceforge.jp>, <gxt@mprc.pku.edu.cn>,
<jdike@addtoit.com>, Heiko Carstens <heiko.carstens@de.ibm.com>,
<linux-s390@vger.kernel.org>, Mike Frysinger <vapier@gentoo.org>,
<uclinux-dist-devel@blackfin.uclinux.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors
Date: Fri, 12 Apr 2013 16:39:01 -0400 [thread overview]
Message-ID: <516870E5.3050901@tilera.com> (raw)
In-Reply-To: <1365016497-32033-4-git-send-email-tj@kernel.org>
On 4/3/2013 3:14 PM, Tejun Heo wrote:
> This patch expands the dummy fallback dump_stack() implementation in
> lib/dump_stack.c such that it prints out debug information (taken from
> x86) and invokes show_stack(NULL, NULL) and drops arch-specific
> dump_stack() implementations in all archs except blackfin. Blackfin's
> dump_stack() does something wonky that I don't understand.
arch/tile has a dump_stack() entry point in assembly (see arch/tile/kernel/entry.S) that passes to _dump_stack(), which passes to dump_stack_regs(), which passes to tile_show_stack(). Similarly, show_stack() passes to tile_show_stack(), which does lots of work to cross into userspace and continue showing the stack if possible, print symbol info for both kernel and userspace, etc. I don't know if that's all supported fully in Tejun's generic version.
Would it make sense for me to look at this after it's merged up into -next and see what tile needs? Unfortunately I'm taking off for a week's vacation so won't be able to do much until after the 23rd.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2013-04-12 20:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 19:14 [PATCHSET v2] arch: unify task dump debug info Tejun Heo
2013-04-03 19:14 ` [PATCH 1/7] x86: don't show trace beyond show_stack(NULL, NULL) Tejun Heo
2013-04-08 16:08 ` Ingo Molnar
2013-04-08 17:57 ` Tejun Heo
2013-04-10 10:35 ` Ingo Molnar
2013-04-10 18:54 ` Tejun Heo
2013-04-10 20:10 ` [PATCH UPDATED 1/7] x86: don't show trace into stacktrace machinery Tejun Heo
2013-04-10 20:10 ` Tejun Heo
2013-04-10 20:22 ` Borislav Petkov
2013-04-10 21:09 ` Tejun Heo
2013-04-10 21:18 ` [PATCH UPDATED v2 " Tejun Heo
2013-04-10 21:18 ` Tejun Heo
2013-04-03 19:14 ` [PATCH 2/7] sparc32: make show_stack() acquire %fp if @_ksp is not specified Tejun Heo
2013-04-03 19:14 ` [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-04-04 7:13 ` Martin Schwidefsky
2013-04-12 20:39 ` Chris Metcalf [this message]
2013-04-12 20:39 ` Chris Metcalf
2013-04-12 21:59 ` Tejun Heo
2013-04-03 19:14 ` [PATCH 4/7] dmi: morph dmi_dump_ids() into dmi_format_ids() which formats into a buffer Tejun Heo
2013-04-03 19:14 ` [PATCH 5/7] dump_stack: implement arch-specific hardware description in task dumps Tejun Heo
2013-04-03 19:14 ` [PATCH 6/7] dump_stack: unify debug information printed by show_regs() Tejun Heo
2013-04-12 20:37 ` Chris Metcalf
2013-04-12 20:37 ` Chris Metcalf
2013-04-03 19:14 ` [PATCH 7/7] arc, print-fatal-signals: reduce duplicated information Tejun Heo
2013-04-08 15:31 ` [PATCHSET v2] arch: unify task dump debug info Tejun Heo
2013-04-11 18:47 ` Tejun Heo
2013-04-12 5:42 ` Ingo Molnar
2013-04-13 1:14 ` rkuo
2013-04-18 14:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516870E5.3050901@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=heiko.carstens@de.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=jdike@addtoit.com \
--cc=jonas@southpole.se \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=liqin.chen@sunplusct.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.