From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Kukjin Kim" <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
"'Ben Dooks'" <ben-linux@fluff.org>,
"'Arnd Bergmann'" <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re[2]: [PATCH 4/4] ARM: s3c24xx: Fix switching FIFO in arch_enable_uart_fifo function
Date: Thu, 04 Apr 2013 22:54:32 +0400 [thread overview]
Message-ID: <1365101672.722585953@f87.mail.ru> (raw)
In-Reply-To: 1362216174-10478-4-git-send-email-shc_work@mail.ru
Hello.
> Alexander Shiyan wrote:
> >
> > When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> > enable FIFO but actually switch command is missing in the code.
> > This patch adds this switch.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> > b/arch/arm/plat-samsung/include/plat/uncompress.h
> > index 438b248..30fedd9 100644
> > --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> > +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> > @@ -130,6 +130,8 @@ static inline void arch_enable_uart_fifo(void)
> > if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> > break;
> > }
> > +
> > + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
>
> Well, I think, if required, this should be moved into 'if (!(fifocon &
> S3C2410_UFCON_FIFOMODE))'.
Already here.
---
WARNING: multiple messages have this Message-ID (diff)
From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[2]: [PATCH 4/4] ARM: s3c24xx: Fix switching FIFO in arch_enable_uart_fifo function
Date: Thu, 04 Apr 2013 22:54:32 +0400 [thread overview]
Message-ID: <1365101672.722585953@f87.mail.ru> (raw)
In-Reply-To: 1362216174-10478-4-git-send-email-shc_work@mail.ru
Hello.
> Alexander Shiyan wrote:
> >
> > When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> > enable FIFO but actually switch command is missing in the code.
> > This patch adds this switch.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> > b/arch/arm/plat-samsung/include/plat/uncompress.h
> > index 438b248..30fedd9 100644
> > --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> > +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> > @@ -130,6 +130,8 @@ static inline void arch_enable_uart_fifo(void)
> > if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> > break;
> > }
> > +
> > + uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
>
> Well, I think, if required, this should be moved into 'if (!(fifocon &
> S3C2410_UFCON_FIFOMODE))'.
Already here.
---
next prev parent reply other threads:[~2013-04-04 18:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 9:22 [PATCH 1/4] ARM: s3c24xx: Removed unneeded dependency on ARCH_S3C24XX for boards Alexander Shiyan
2013-03-02 9:22 ` Alexander Shiyan
2013-03-02 9:22 ` [PATCH 2/4] ARM: s3c24xx: Removed unneeded dependency on CPU_S3C2410 Alexander Shiyan
2013-03-02 9:22 ` Alexander Shiyan
2013-03-02 9:22 ` [PATCH 3/4] ARM: s3c24xx: Removed unneeded dependency on CPU_S3C2412 Alexander Shiyan
2013-03-02 9:22 ` Alexander Shiyan
2013-03-02 9:22 ` [PATCH 4/4] ARM: s3c24xx: Fix switching FIFO in arch_enable_uart_fifo function Alexander Shiyan
2013-03-02 9:22 ` Alexander Shiyan
2013-04-04 1:01 ` Kukjin Kim
2013-04-04 1:01 ` Kukjin Kim
2013-04-04 18:54 ` Alexander Shiyan [this message]
2013-04-04 18:54 ` Re[2]: " Alexander Shiyan
2013-03-02 11:43 ` [PATCH 1/4] ARM: s3c24xx: Removed unneeded dependency on ARCH_S3C24XX for boards Arnd Bergmann
2013-03-02 11:43 ` Arnd Bergmann
2013-03-02 12:00 ` Re[2]: " Alexander Shiyan
2013-03-02 12:00 ` Alexander Shiyan
2013-04-04 1:02 ` Kukjin Kim
2013-04-04 1:02 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365101672.722585953@f87.mail.ru \
--to=shc_work@mail.ru \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.