From: geoff@infradead.org (Geoff Levand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code
Date: Fri, 05 Apr 2013 09:46:50 -0700 [thread overview]
Message-ID: <1365180410.24496.67.camel@smoke> (raw)
In-Reply-To: <515E9474.2070100@arm.com>
Hi Marc,
On Fri, 2013-04-05 at 10:08 +0100, Marc Zyngier wrote:
> On 04/04/13 23:10, Geoff Levand wrote:
> > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote:
> >> + @ Jump to the trampoline page
> >> + ldr r2, =#PAGE_MASK
> >> + adr r3, target
> >> + bic r3, r3, r2
> >> + ldr r2, =#TRAMPOLINE_VA
> >> + add r3, r3, r2
> >> + mov pc, r3
> >
> > I guess you need 'ldr r2, =PAGE_MASK'.
> >
> > arch/arm/kvm/init.S:114: Error: bad expression -- `ldr r2,=#(~((1<<12)-1))'
> > arch/arm/kvm/init.S:117: Error: bad expression -- `ldr r2,=#0xffff0000'
>
> Oddly enough, this code compiles perfectly fine on my box.
> What's your compiler/binutils versions?
I thought # was for an immediate value in instructions. This
is an assembler pseudo-instruction, and based on the ARM manual
here I would think your coding should fail:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473i/Chdcegci.html
I use the current arm-linux-gnueabihf cross toolchain packages from
Ubuntu 12.04:
arm-linux-gnueabihf-gcc-4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
GNU assembler (GNU Binutils for Ubuntu) 2.22
-Geoff
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoff@infradead.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "cdall@cs.columbia.edu" <cdall@cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code
Date: Fri, 05 Apr 2013 09:46:50 -0700 [thread overview]
Message-ID: <1365180410.24496.67.camel@smoke> (raw)
In-Reply-To: <515E9474.2070100@arm.com>
Hi Marc,
On Fri, 2013-04-05 at 10:08 +0100, Marc Zyngier wrote:
> On 04/04/13 23:10, Geoff Levand wrote:
> > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote:
> >> + @ Jump to the trampoline page
> >> + ldr r2, =#PAGE_MASK
> >> + adr r3, target
> >> + bic r3, r3, r2
> >> + ldr r2, =#TRAMPOLINE_VA
> >> + add r3, r3, r2
> >> + mov pc, r3
> >
> > I guess you need 'ldr r2, =PAGE_MASK'.
> >
> > arch/arm/kvm/init.S:114: Error: bad expression -- `ldr r2,=#(~((1<<12)-1))'
> > arch/arm/kvm/init.S:117: Error: bad expression -- `ldr r2,=#0xffff0000'
>
> Oddly enough, this code compiles perfectly fine on my box.
> What's your compiler/binutils versions?
I thought # was for an immediate value in instructions. This
is an assembler pseudo-instruction, and based on the ARM manual
here I would think your coding should fail:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473i/Chdcegci.html
I use the current arm-linux-gnueabihf cross toolchain packages from
Ubuntu 12.04:
arm-linux-gnueabihf-gcc-4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
GNU assembler (GNU Binutils for Ubuntu) 2.22
-Geoff
next prev parent reply other threads:[~2013-04-05 16:46 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 13:25 [PATCH 0/7] ARM: KVM: Revamping the HYP init code for fun and profit Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-02 13:25 ` [PATCH 1/7] ARM: KVM: simplify HYP mapping population Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 23:13 ` Christoffer Dall
2013-04-03 23:13 ` Christoffer Dall
2013-04-04 12:35 ` Marc Zyngier
2013-04-04 12:35 ` Marc Zyngier
2013-04-02 13:25 ` [PATCH 2/7] ARM: KVM: fix HYP mapping limitations around zero Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 23:14 ` Christoffer Dall
2013-04-03 23:14 ` Christoffer Dall
2013-04-04 12:40 ` Marc Zyngier
2013-04-04 12:40 ` Marc Zyngier
2013-04-02 13:25 ` [PATCH 3/7] ARM: KVM: move to a KVM provided HYP idmap Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 9:43 ` Will Deacon
2013-04-03 9:43 ` Will Deacon
2013-04-03 9:46 ` Marc Zyngier
2013-04-03 9:46 ` Marc Zyngier
2013-04-03 23:14 ` Christoffer Dall
2013-04-03 23:14 ` Christoffer Dall
2013-04-02 13:25 ` [PATCH 4/7] ARM: KVM: enforce page alignment for identity mapped code Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 9:50 ` Will Deacon
2013-04-03 9:50 ` Will Deacon
2013-04-03 10:00 ` Marc Zyngier
2013-04-03 10:00 ` Marc Zyngier
2013-04-03 23:15 ` Christoffer Dall
2013-04-03 23:15 ` Christoffer Dall
2013-04-04 10:47 ` Marc Zyngier
2013-04-04 10:47 ` Marc Zyngier
2013-04-04 15:32 ` Christoffer Dall
2013-04-04 15:32 ` Christoffer Dall
2013-04-02 13:25 ` [PATCH 5/7] ARM: KVM: parametrize HYP page table freeing Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 23:15 ` Christoffer Dall
2013-04-03 23:15 ` Christoffer Dall
2013-04-02 13:25 ` [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 10:07 ` Will Deacon
2013-04-03 10:07 ` Will Deacon
2013-04-03 10:38 ` Marc Zyngier
2013-04-03 10:38 ` Marc Zyngier
2013-04-03 23:15 ` Christoffer Dall
2013-04-03 23:15 ` Christoffer Dall
2013-04-04 11:05 ` Marc Zyngier
2013-04-04 11:05 ` Marc Zyngier
2013-04-03 23:15 ` Christoffer Dall
2013-04-03 23:15 ` Christoffer Dall
2013-04-04 12:52 ` Marc Zyngier
2013-04-04 12:52 ` Marc Zyngier
2013-04-04 22:10 ` Geoff Levand
2013-04-04 22:10 ` Geoff Levand
2013-04-05 9:08 ` Marc Zyngier
2013-04-05 9:08 ` Marc Zyngier
2013-04-05 16:46 ` Geoff Levand [this message]
2013-04-05 16:46 ` Geoff Levand
2013-04-05 16:54 ` Marc Zyngier
2013-04-05 16:54 ` Marc Zyngier
2013-04-18 15:54 ` Russell King - ARM Linux
2013-04-18 15:54 ` Russell King - ARM Linux
2013-04-18 16:01 ` Marc Zyngier
2013-04-18 16:01 ` Marc Zyngier
2013-04-02 13:25 ` [PATCH 7/7] ARM: KVM: perform HYP initilization for hotplugged CPUs Marc Zyngier
2013-04-02 13:25 ` Marc Zyngier
2013-04-03 23:16 ` Christoffer Dall
2013-04-03 23:16 ` Christoffer Dall
2013-04-03 23:18 ` [PATCH 0/7] ARM: KVM: Revamping the HYP init code for fun and profit Christoffer Dall
2013-04-03 23:18 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365180410.24496.67.camel@smoke \
--to=geoff@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.